From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Alexandre Derumier <aderumier@odiso.com>
Subject: Re: [pve-devel] [PATCH pve-network] vnet/subnet : add skipdns option
Date: Tue, 13 Jul 2021 06:41:42 +0200 [thread overview]
Message-ID: <6788b7d7-f389-606b-b117-d72b0c585b4d@proxmox.com> (raw)
In-Reply-To: <20210711224833.66035-1-aderumier@odiso.com>
On 12.07.21 00:48, Alexandre Derumier wrote:
> allow to register ip to ipam without dns registration.
> can be used for temp/pending ip for example
>
> Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
> ---
> PVE/Network/SDN/Subnets.pm | 70 ++++++++++++++++++++++----------------
> PVE/Network/SDN/Vnets.pm | 16 ++++-----
> 2 files changed, 49 insertions(+), 37 deletions(-)
>
looks OK, I wonder if we'd be more future proof if we went for adding a %param hash
(or as reference with $param) instead, with the skip dns options as property?
Not to sure how much change potential there's here.
btw., did you checked out newer ifupdown2 already? I saw that upstream added a changelog
entry already, but not yet tagged as release.
next prev parent reply other threads:[~2021-07-13 4:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 22:48 Alexandre Derumier
2021-07-13 4:41 ` Thomas Lamprecht [this message]
2021-07-13 6:17 ` alexandre derumier
2021-07-13 6:56 ` alexandre derumier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6788b7d7-f389-606b-b117-d72b0c585b4d@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=aderumier@odiso.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.