Re: [pbs-devel] [PATCH proxmox-backup] ui: add consent banner maxLength

From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] ui: add consent banner maxLength
Date: Mon, 9 Dec 2024 12:29:02 +0100	[thread overview]
Message-ID: <6762bcfb-a61e-4ad6-a9ed-9d3f882e41ff@proxmox.com> (raw)
In-Reply-To: <20241206122357.181200-1-g.goller@proxmox.com>

Am 06.12.24 um 13:23 schrieb Gabriel Goller:
> Add a maxLength of 24000 to the consentBanner. This is the same limit as
> in PVE, and while it makes sense there (file size limits in pmxcfs), it
> acts more as an arbitrary stop-gap here.
> 
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  www/config/NodeOptionView.js | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/www/config/NodeOptionView.js b/www/config/NodeOptionView.js
> index c327356f7f24..966e6d719469 100644
> --- a/www/config/NodeOptionView.js
> +++ b/www/config/NodeOptionView.js
> @@ -59,6 +59,9 @@ Ext.define('PBS.NodeOptionView', {
>  	    name: 'consent-text',
>  	    text: gettext('Consent Text'),
>  	    deleteEmpty: true,
> +	    fieldOpts: {
> +		maxLength: 24000,

But that's frontend only? So not really a limitation for anybody.
While it is great to have for UX, the real check should go into
the backend.

_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel