From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Kral <d.kral@proxmox.com>
Subject: Re: [pve-devel] [PATCH ha-manager 6/9] config, manager: factor out resource motion info logic
Date: Mon, 19 Jan 2026 16:00:47 +0100 [thread overview]
Message-ID: <673bbd53-e8af-4f60-bec9-e43871950261@proxmox.com> (raw)
In-Reply-To: <20251215155334.476984-7-d.kral@proxmox.com>
Am 15.12.25 um 4:55 PM schrieb Daniel Kral:
> The logic in execute_migration(...) and get_resource_motion_info(...) to
> gather dependent and blocking HA resources is equivalent and should also
> be the same for consistency, so factor them out as a separate helper.
>
> The PVE::HA::Helpers package is introduced since there does not exist a
> package for shared logic between packages, which cannot depend on each
> other (e.g. Manager and Config, LRM and CRM, etc.) and PVE::HA::Tools is
> not the right place for these.
It is a rather specific helper and PVE::HA::Helpers sounds very general.
Could we also put it in PVE::HA::Rules::Helpers or somewhere else below
PVE::HA::Rules or is there a good reason not to?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2026-01-19 15:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 15:52 [pve-devel] [PATCH-SERIES container/ha-manager/manager/qemu-server 00/12] HA node affinity blockers (#1497) Daniel Kral
2025-12-15 15:52 ` [pve-devel] [PATCH ha-manager 1/9] ha: put source files on individual new lines Daniel Kral
2025-12-15 15:52 ` [pve-devel] [PATCH ha-manager 2/9] d/pve-ha-manager.install: remove duplicate Config.pm Daniel Kral
2025-12-15 15:52 ` [pve-devel] [PATCH ha-manager 3/9] config: group and sort use statements Daniel Kral
2025-12-15 15:52 ` [pve-devel] [PATCH ha-manager 4/9] manager: " Daniel Kral
2025-12-15 15:52 ` [pve-devel] [PATCH ha-manager 5/9] manager: report all reasons when resources are blocked from migration Daniel Kral
2025-12-15 15:52 ` [pve-devel] [PATCH ha-manager 6/9] config, manager: factor out resource motion info logic Daniel Kral
2026-01-19 15:00 ` Fiona Ebner [this message]
2026-01-19 15:24 ` Daniel Kral
2026-01-20 9:25 ` Daniel Kral
2026-01-20 9:35 ` Fiona Ebner
2026-01-20 10:37 ` Daniel Kral
2025-12-15 15:52 ` [pve-devel] [PATCH ha-manager 7/9] tests: add test cases for migrating resources with node affinity rules Daniel Kral
2026-01-19 15:00 ` Fiona Ebner
2025-12-15 15:52 ` [pve-devel] [PATCH ha-manager 8/9] handle strict node affinity rules in manual migrations Daniel Kral
2025-12-15 15:52 ` [pve-devel] [PATCH ha-manager 9/9] handle node affinity rules with failback " Daniel Kral
2026-01-19 15:00 ` Fiona Ebner
2026-01-19 15:41 ` Daniel Kral
2026-01-20 9:52 ` Fiona Ebner
2025-12-15 15:52 ` [pve-devel] [PATCH qemu-server 1/1] api: migration preconditions: add node affinity as blocking cause Daniel Kral
2026-01-19 15:00 ` Fiona Ebner
2026-01-19 16:55 ` Daniel Kral
2026-01-20 9:07 ` Fiona Ebner
2025-12-15 15:52 ` [pve-devel] [PATCH container " Daniel Kral
2025-12-15 15:52 ` [pve-devel] [PATCH manager 1/1] ui: migrate: display precondition messages for ha node affinity Daniel Kral
2026-01-19 15:00 ` [pve-devel] [PATCH-SERIES container/ha-manager/manager/qemu-server 00/12] HA node affinity blockers (#1497) Fiona Ebner
2026-01-20 15:33 ` [pve-devel] superseded: " Daniel Kral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=673bbd53-e8af-4f60-bec9-e43871950261@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.