[pve-devel] [PATCH qemu-server v2] apply pending changes at vm stop only if the section is not empty

[pve-devel] [PATCH qemu-server v2] apply pending changes at vm stop only if the section is not empty

[Oguz Bektas]

we also have the same skipping logic when starting vms, this way we
avoid calling 'write_config' when there are no present changes to
commit.

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
v1->v2:
* keep using the hardcoded 1 for vm_stop_cleanup call since we do an early return anyway


 PVE/QemuServer.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 45b704d..0071a06 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -4998,6 +4998,8 @@ sub vmconfig_delete_or_detach_drive {
 sub vmconfig_apply_pending {
     my ($vmid, $conf, $storecfg, $errors) = @_;
 
+    return if !scalar(keys %{$conf->{pending}});
+
     my $add_apply_error = sub {
 	my ($opt, $msg) = @_;
 	my $err_msg = "unable to apply pending change $opt : $msg";
-- 
2.30.2

[pve-devel] applied: [PATCH qemu-server v2] apply pending changes at vm stop only if the section is not empty

[Thomas Lamprecht]

On 02.12.21 12:43, Oguz Bektas wrote:
> we also have the same skipping logic when starting vms, this way we
> avoid calling 'write_config' when there are no present changes to
> commit.
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> v1->v2:
> * keep using the hardcoded 1 for vm_stop_cleanup call since we do an early return anyway
> 
> 
>  PVE/QemuServer.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

applied, albeit I modified/added a bit to the commit message to clarify why
this is nicer to do (or in this case rather not to do). thanks!