From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Oguz Bektas <o.bektas@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server v2] apply pending changes at vm stop only if the section is not empty
Date: Thu, 2 Dec 2021 19:28:00 +0100 [thread overview]
Message-ID: <672f96e0-a686-cfbf-8bb1-2082ac7473af@proxmox.com> (raw)
In-Reply-To: <20211202114303.350940-1-o.bektas@proxmox.com>
On 02.12.21 12:43, Oguz Bektas wrote:
> we also have the same skipping logic when starting vms, this way we
> avoid calling 'write_config' when there are no present changes to
> commit.
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> v1->v2:
> * keep using the hardcoded 1 for vm_stop_cleanup call since we do an early return anyway
>
>
> PVE/QemuServer.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, albeit I modified/added a bit to the commit message to clarify why
this is nicer to do (or in this case rather not to do). thanks!
prev parent reply other threads:[~2021-12-02 18:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 11:43 [pve-devel] " Oguz Bektas
2021-12-02 18:28 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=672f96e0-a686-cfbf-8bb1-2082ac7473af@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.