From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup v2 1/3] rest-server: cleanup_old_tasks: improve error handling
Date: Thu, 7 Apr 2022 14:06:01 +0200 [thread overview]
Message-ID: <66b44af7-4a22-a97e-41bf-4074360462a8@proxmox.com> (raw)
In-Reply-To: <20220328075419.1020418-1-d.csapak@proxmox.com>
On 28.03.22 09:54, Dominik Csapak wrote:
> by not bubbling up most errors, and continuing on. this avoids that we
> stop cleaning up because e.g. one directory was missing.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * ignore only ENOENT error for task log archive dirs,
> log all other errors
> * use task_log instead of log::errors, this way the task will end on a
> 'WARNINGS' and the user sees that something was wrong with it
> this also has the advantage that the errors really go into the task
> log instead of the syslog
> * improve error messages
>
> proxmox-rest-server/src/worker_task.rs | 38 ++++++++++++++++++++------
> src/bin/proxmox-backup-proxy.rs | 2 +-
> 2 files changed, 30 insertions(+), 10 deletions(-)
>
>
applied, with the merge conflict from a recent rustfmt resolved and the followup
discussed off-list to fix the off-by-one file deletion the series had, thanks!
prev parent reply other threads:[~2022-04-07 12:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-28 7:54 [pbs-devel] " Dominik Csapak
2022-03-28 7:54 ` [pbs-devel] [PATCH proxmox-backup v2 2/3] config/node: add 'task_log_max_days' config Dominik Csapak
2022-03-28 7:54 ` [pbs-devel] [PATCH proxmox-backup v2 3/3] rest-server: add option to rotate task logs by 'max_days' instead of 'max_files' Dominik Csapak
2022-04-07 12:06 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66b44af7-4a22-a97e-41bf-4074360462a8@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.