From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit] node: repos: Use won't rather than don't
Date: Fri, 24 Nov 2023 16:33:12 +0100 (CET) [thread overview]
Message-ID: <664251523.1602.1700839992094@webmail.proxmox.com> (raw)
In-Reply-To: <20231124145815.179803-1-m.sandoval@proxmox.com>
Do you also plan to fix those typos in the translation files?
Else we need to re-tralstale them for all languages!
> On 24.11.2023 15:58 CET Maximiliano Sandoval <m.sandoval@proxmox.com> wrote:
>
>
> It would be preferable to use "won't" but I would rather err on the safe
> side when it comes to escapes in gettext.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> src/node/APTRepositories.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js
> index 4e74da2..f27e713 100644
> --- a/src/node/APTRepositories.js
> +++ b/src/node/APTRepositories.js
> @@ -471,7 +471,7 @@ Ext.define('Proxmox.node.APTRepositories', {
>
> if (!enterprise && !nosubscription && !test) {
> addCritical(
> - Ext.String.format(gettext('No {0} repository is enabled, you do not get any updates!'), vm.get('product')),
> + Ext.String.format(gettext('No {0} repository is enabled, you would not get any updates!'), vm.get('product')),
> );
> } else if (errors.length > 0) {
> // nothing extra, just avoid that we show "get updates"
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2023-11-24 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 14:58 Maximiliano Sandoval
2023-11-24 15:33 ` Dietmar Maurer [this message]
2023-11-24 15:41 ` Lukas Wagner
2023-11-24 16:08 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=664251523.1602.1700839992094@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.