Re: [PATCH ha-manager v2] resources: Expand max_restart option

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 03.03.26 um 14:22 schrieb Maximiliano Sandoval:
> When read next to `max_relocate` it is not clear which happens first
> after a service fails to start.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> 
> ---
> 
> Differences from v1:
>  - Incorporate feedback. Namely, "the service will be attempted to be relocated"
>    was a bit too convoluted.
> 
>  src/PVE/HA/Resources.pm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm
> index 68d9d16..404f6dc 100644
> --- a/src/PVE/HA/Resources.pm
> +++ b/src/PVE/HA/Resources.pm
> @@ -73,7 +73,8 @@ EODESC
>          },
>          max_restart => {
>              description => "Maximal number of tries to restart the service on"
> -                . " a node after its start failed.",
> +                . " a node after its start failed. When reached, the HA manager will try to"
> +                . " relocate the service to an eligible node.",


IIRC we decided to try using the term "resources" for the VM/CTs managed by HA
and "services" more for the daemons for new docs/description (and Someday™ clean
up the existing usage). Can be easily fixed up on applying, just wanted to ensure
I did not misremember (CCing also Dano for that)

>              type => 'integer',
>              optional => 1,
>              default => 1,