[PATCH pve-manager] ui: processor edit: fix clipped accel hint in VM creation wizard

[PATCH pve-manager] ui: processor edit: fix clipped accel hint in VM creation wizard

[Arthur Bied-Charreton]

The 200px height on the flag selector leaves no room for the
acceleration hint below it in the wizard's layout.

Decrease the flag selector's default height to 180px so everything
fits.

Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 www/manager6/form/VMCPUFlagSelector.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
index c6f8f87a..a62353aa 100644
--- a/www/manager6/form/VMCPUFlagSelector.js
+++ b/www/manager6/form/VMCPUFlagSelector.js
@@ -16,7 +16,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
     selectable: false,
 
     scrollable: 'y',
-    height: 200,
+    height: 180,
 
     emptyText: gettext('No CPU flags available'),
 
-- 
2.47.3

Re: [PATCH pve-manager] ui: processor edit: fix clipped accel hint in VM creation wizard

[Thomas Lamprecht]

Am 19.05.26 um 11:57 schrieb Arthur Bied-Charreton:
> The 200px height on the flag selector leaves no room for the
> acceleration hint below it in the wizard's layout.
> 
> Decrease the flag selector's default height to 180px so everything
> fits.
> 
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> ---
>  www/manager6/form/VMCPUFlagSelector.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/www/manager6/form/VMCPUFlagSelector.js b/www/manager6/form/VMCPUFlagSelector.js
> index c6f8f87a..a62353aa 100644
> --- a/www/manager6/form/VMCPUFlagSelector.js
> +++ b/www/manager6/form/VMCPUFlagSelector.js
> @@ -16,7 +16,7 @@ Ext.define('PVE.form.VMCPUFlagSelector', {
>      selectable: false,
>  
>      scrollable: 'y',
> -    height: 200,
> +    height: 180,
>  
>      emptyText: gettext('No CPU flags available'),
>  
thanks, I rechecked the UI/UX another time here and found the permanently visible
hint a bit to alarming/distracting, especially given that the TCG case is rather
an edge case.

After trying a few things I then went for increasing the wizard base size a bit [0]
and moving the hint as simple string inside the VMCPUFlagSelector's bottom bar, i.e.
to the right of the "Only show flags supported by at least one node" checkbox, and
only made it visible for VM vCPU edit case, as in the datacenter custom vCPU case
it's more explicit due to the KVM/TCG filter anyway.

[0]: https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=7de57108172a31eebe35a565d3c5b1966a32a9a7
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=db71b84bbc08482130c7d51db24a416ab7af74f7