Re: [pbs-devel] applied: [PATCH v3 proxmox-backup] partial fix #5560: client: periodically show backup progress

[Christian Ebner <c.ebner@proxmox.com>]

On 10/18/24 09:20, Thomas Lamprecht wrote:
> Am 17/10/2024 um 17:53 schrieb Christian Ebner:
>> On 10/17/24 17:02, Thomas Lamprecht wrote:
>>> applied, thanks! With some opinionated line-reduction as follow-up (opinionated
>>> because it was OK as is too, and I could have noticed that on the previous
>>> review, sorry...)
>>>
>>> Did not think it through at all, but maybe it makes sense to add the uploaded
>>> size also to the upload stats.
>>
>> For now I do not see much benefit for this, as after consuming the full
>> upload stream there are no more chunks queued for upload, so the
>> counters already present in `UploadStats` contain the same information.
>>
>> And this information is already shown to the user at the end of the
>> upload as, e.g.:
>> ```
>> had to backup 1.66 GiB of 285.242 GiB (compressed 1.274 GiB) in 58.52 s
>> (average 29.053 MiB/s)
>> ```
> 
> Ack, thanks for clearing this up to me.

One thing still came to mind yesterday though:
Progress logging is now enabled unconditionally, and as is it is not 
possible to disable it or configure the interval.

So I plan to send a patch to make the progress log output opt-in, and 
make the interval configurable within a meaningful value range (maybe 
within 0s to 3600s?).

Something like:
```
proxmox-backup-client backup root.pxar:/ --progress-log-interval=10
```

And disable progress log output for a value of 0 or the optional 
parameter is not given.

That would also allow to more flexibly control the behavior when being 
invoked by vzdump.

What are your opinions on that?


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel