From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: Re: [pbs-devel] [RFC proxmox-backup] fix #5710: api: backup: stat known chunks during backup
Date: Tue, 17 Sep 2024 09:23:02 +0200 [thread overview]
Message-ID: <6567827a-18ec-4170-a216-135b77fdf3a3@proxmox.com> (raw)
In-Reply-To: <20240916101740.4nfm6pjhiapppno5@luna.proxmox.com>
On 9/16/24 12:17, Gabriel Goller wrote:
> On 13.09.2024 15:59, Christian Ebner wrote:
>> In order to reduce the impact, stat the list of known chunks twice
>> during backup:
>> - during registration of a known chunk
>> - when finishing the backup
>>
>> The first stat is to early on detect missing chunks, the latter
>> assures that all (known and newly registered) chunks are present on
>> the datastore after the backup run.
>>
>> If a missing chunk is detected, the backup run itself will fail and
>> the previous backup snapshots verify state is set to failed.
>> This prevents the same snapshot from being reused by another,
>> subsequent backup job.
>
> I wonder if we need the first option. We could only `stat` the chunks at
> the end of the backup to improve performance.
The first stat is intended to early detect and fail the backup run on
missing chunks, but you are right, to minimize the performance impact
only the final stat when finishing the backup run is enough.
Will drop the first check altogether in a new version of the patch.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2024-09-17 7:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 13:59 Christian Ebner
2024-09-13 15:23 ` Dietmar Maurer
2024-09-17 7:19 ` Christian Ebner
2024-09-17 11:40 ` Christian Ebner
2024-09-18 8:54 ` Dietmar Maurer
2024-09-16 10:17 ` Gabriel Goller
2024-09-17 7:23 ` Christian Ebner [this message]
2024-09-20 13:42 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6567827a-18ec-4170-a216-135b77fdf3a3@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.