From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pve-devel] [RFC PATCH 1/2] config: allow hypens and dots in config keys
Date: Mon, 21 Oct 2024 14:19:00 +0200 [thread overview]
Message-ID: <6539830b-5d20-4cfc-8b8a-bf08753369c2@proxmox.com> (raw)
In-Reply-To: <20240924143502.361901-1-m.sandoval@proxmox.com>
Am 24.09.24 um 16:35 schrieb Maximiliano Sandoval:
> The first character still has to be a letter.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> PVE/QemuServer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index b26da505..1566cf91 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -2382,7 +2382,7 @@ sub parse_vm_config {
> } else {
> $handle_error->("vm $vmid - property 'delete' is only allowed in [PENDING]\n");
> }
> - } elsif ($line =~ m/^([a-z][a-z_]*\d*):\s*(.+?)\s*$/) {
> + } elsif ($line =~ m/^([a-z][a-z_\.-]*\d*):\s*(.+?)\s*$/) {
> my $key = $1;
> my $value = $2;
> if ($section eq 'cloudinit') {
Regarding the hyphen, see also:
https://lore.proxmox.com/pve-devel/7c911e11-d1cb-415b-9282-b40faa34dc9b@proxmox.com/#t
Also friendly ping for @Thomas for that mail, in particular, for where
this should be documented.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-10-21 12:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 14:35 Maximiliano Sandoval
2024-09-24 14:35 ` [pve-devel] [RFC PATCH 2/2] config: add systemd credentials support Maximiliano Sandoval
2024-10-22 8:29 ` Fabian Grünbichler
2025-04-02 14:36 ` Maximiliano Sandoval
2024-10-21 12:19 ` Fiona Ebner [this message]
2024-10-22 6:45 ` [pve-devel] [RFC PATCH 1/2] config: allow hypens and dots in config keys Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6539830b-5d20-4cfc-8b8a-bf08753369c2@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.