all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pbs-devel] [PATCH pbs 2/6] clippy fixes: the borrowed expression implements the required traits
Date: Fri, 16 Jun 2023 09:56:12 +0200	[thread overview]
Message-ID: <651c5e74-85f6-ee01-471e-e344739bbc12@proxmox.com> (raw)
In-Reply-To: <20230616073541.28487-2-m.sandoval@proxmox.com>

Am 16/06/2023 um 09:35 schrieb Maximiliano Sandoval:
> https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

missing newline here before S-o-b line

While at it, and no hard feelings here, but it could be good to have the core
information of the lint here directly, I don't like to chase links, especially
for minor things, and a lot go dead after a while,

E.g., as quote above the link, like:

> Why is this bad?
> Suggests that the receiver of the expression borrows the expression.


> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  src/api2/admin/datastore.rs    | 2 +-
>  src/api2/config/acme.rs        | 4 ++--
>  src/api2/tape/restore.rs       | 2 +-
>  src/auth.rs                    | 2 +-
>  src/config/mod.rs              | 4 ++--
>  src/config/tfa.rs              | 2 +-
>  src/server/jobstate.rs         | 2 +-
>  src/tape/drive/virtual_tape.rs | 8 ++++----
>  src/tape/encryption_keys.rs    | 2 +-
>  src/tape/media_catalog.rs      | 2 +-
>  src/tools/disks/mod.rs         | 2 +-
>  src/tools/disks/zfs.rs         | 2 +-
>  12 files changed, 17 insertions(+), 17 deletions(-)
> 





  reply	other threads:[~2023-06-16  7:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-16  7:35 [pbs-devel] [PATCH pbs 1/6] quemu_helper: run rustfmt Maximiliano Sandoval
2023-06-16  7:35 ` [pbs-devel] [PATCH pbs 2/6] clippy fixes: the borrowed expression implements the required traits Maximiliano Sandoval
2023-06-16  7:56   ` Thomas Lamprecht [this message]
2023-06-16  7:35 ` [pbs-devel] [PATCH pbs 3/6] clippy fixes: use of ok_or followed by a function call Maximiliano Sandoval
2023-06-16  7:35 ` [pbs-devel] [PATCH pbs 4/6] clippy fixes: casting to the same type is unnecessary Maximiliano Sandoval
2023-06-16  7:35 ` [pbs-devel] [PATCH pbs 5/6] clippy fixes: Box::new(_) of default value Maximiliano Sandoval
2023-06-16  7:35 ` [pbs-devel] [PATCH pbs 6/6] clippy fixes: deref which would be done by auto-deref Maximiliano Sandoval
2023-06-16  8:02 ` [pbs-devel] applied: [PATCH pbs 1/6] quemu_helper: run rustfmt Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=651c5e74-85f6-ee01-471e-e344739bbc12@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal