Re: [pve-devel] [PATCH pve-manager v2] postinst: filter rbds in lvm

[Friedrich Weber <f.weber@proxmox.com>]

Tested-by: Friedrich Weber <f.weber@proxmox.com>

Tried a couple of upgrades from PVE 7 to PVE 8 (including pve-manager
with this patch). When upgrading, dpkg asks (in most cases) whether to
keep local /etc/lvm/lvm.conf or install package maintainer version, so I
tried both answers. Results were as I'd expect. I'm showing the pre- and
post-upgrade contents of the `devices {}` block below.

* default PVE 7 lvm.conf (with zvol filter):

** keeping local version
   => post-upgrade lvm.conf:
     # added by pve-manager to avoid scanning ZFS zvols and Ceph rbds
     # global_filter=["r|/dev/zd.*|"]
     global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"]

** installing package maintainer version
   => post-upgrade lvm.conf:
     # added by pve-manager to avoid scanning ZFS zvols and Ceph rbds
     global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"]


* custom lvm.conf 7 with "# added" marker:
     # added by pve-manager to avoid scanning ZFS zvols
     global_filter=["r|/dev/zd.*|",
		    "r|/dev/foo|"]

** keeping local version
   => custom config is kept and untouched

** installing package maintainer version
    => post-upgrade lvm.conf:
     # added by pve-manager to avoid scanning ZFS zvols and Ceph rbds
     global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"]

* custom lvm.conf on PVE 7 without "# added" marker:
     global_filter=["r|/dev/zd.*|", "r|/dev/foo|"]

** keeping local version:
   => custom config is kept and untouched

** install package maintainer version
    => post-upgrade lvm.conf:
     # added by pve-manager to avoid scanning ZFS zvols and Ceph rbds
     global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"]

* upstream unmodified lvm.conf without any global_filter
    LVM does not ask which version to take
    => post-upgrade lvm.conf:
     # added by pve-manager to avoid scanning ZFS zvols and Ceph rbds
     global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"]