* [pve-devel] applied: [PATCH qemu-server] set resume parameter for vm_start_nolock if there is a vmstate
[not found] <20200707082003.17274-1-f.ebner@proxmox.com>
@ 2020-07-13 10:38 ` Thomas Lamprecht
0 siblings, 0 replies; only message in thread
From: Thomas Lamprecht @ 2020-07-13 10:38 UTC (permalink / raw)
To: PVE development discussion, Fabian Ebner
On 07.07.20 10:20, Fabian Ebner wrote:
> In config_to_command, '-loadstate' will be added whenever there is a
> vmstate in the config. But in vm_start_nolock, the resume parameter
> is used to calculate the appropriate timeout and to remove the vmstate
> after the start. The resume parameter was only set if there is a
> 'suspended' lock, but apparently [0] we cannot rely on the lock to be
> set if and only if there is a vmstate.
>
> [0]: https://forum.proxmox.com/threads/task-error-start-failed.72450
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/QemuServer.pm | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>
Was initially a bit unsure about this, but as the addition of "loadstate" happens
since quite a bit this makes it at least work (again), so applied, thanks!
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2020-07-13 10:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20200707082003.17274-1-f.ebner@proxmox.com>
2020-07-13 10:38 ` [pve-devel] applied: [PATCH qemu-server] set resume parameter for vm_start_nolock if there is a vmstate Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal