all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: PVE development discussion <pve-devel@pve.proxmox.com>,
	Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] set resume parameter for vm_start_nolock if there is a vmstate
Date: Mon, 13 Jul 2020 12:38:03 +0200	[thread overview]
Message-ID: <640a9632-1ecd-e6ea-ac02-1b2c897d25db@proxmox.com> (raw)
In-Reply-To: <20200707082003.17274-1-f.ebner@proxmox.com>

On 07.07.20 10:20, Fabian Ebner wrote:
> In config_to_command, '-loadstate' will be added whenever there is a
> vmstate in the config. But in vm_start_nolock, the resume parameter
> is used to calculate the appropriate timeout and to remove the vmstate
> after the start. The resume parameter was only set if there is a
> 'suspended' lock, but apparently [0] we cannot rely on the lock to be
> set if and only if there is a vmstate.
> 
> [0]: https://forum.proxmox.com/threads/task-error-start-failed.72450
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  PVE/QemuServer.pm | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
>

Was initially a bit unsure about this, but as the addition of "loadstate" happens
since quite a bit this makes it at least work (again), so applied, thanks!




           reply	other threads:[~2020-07-13 10:38 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20200707082003.17274-1-f.ebner@proxmox.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=640a9632-1ecd-e6ea-ac02-1b2c897d25db@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@pve.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal