all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v2 2/2] backup-proxy: fix api log reopen send_command calls
Date: Mon, 11 Oct 2021 14:57:38 +0200	[thread overview]
Message-ID: <637c31e5-7c5b-065a-811d-ccd54eeaaa1b@proxmox.com> (raw)
In-Reply-To: <20211011121432.1006944-2-d.csapak@proxmox.com>

On 11.10.21 14:14, Dominik Csapak wrote:
> if we give a string to send_command, it gets to the receiving end as a
> string again (not an object), and the command fails with:
> 
> 'unable to parse parameters (expected json object)'
> 
> Instead, use send_raw_command which expects the string. Also refactor
> the identical command strings.
> 
> Fixes: commit 45b8a0327f21f048bb4384bafc292954358b5651
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * include fixed commit in commit message
> * use send_raw_command with the original strings
> 
>  src/bin/proxmox-backup-proxy.rs | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
>

applied this one for now but dropped the factoring out of the command, not really
worth it IMO and I prefer to keep (initial) change noise small for those things, thanks!

Also did a semantic backport to the stable-1 branch, cherry-picking is rather out of
the window with that big bunch of restructuring that happend in the last weeks/months.




  reply	other threads:[~2021-10-11 12:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11 12:14 [pbs-devel] [PATCH proxmox-backup v2 1/2] rest-server/worker-task: replace newlines with '\n' in task result Dominik Csapak
2021-10-11 12:14 ` [pbs-devel] [PATCH proxmox-backup v2 2/2] backup-proxy: fix api log reopen send_command calls Dominik Csapak
2021-10-11 12:57   ` Thomas Lamprecht [this message]
2021-10-11 13:12 ` [pbs-devel] [PATCH proxmox-backup v2 1/2] rest-server/worker-task: replace newlines with '\n' in task result Thomas Lamprecht
2021-10-11 13:14   ` Dominik Csapak
2021-10-11 13:23     ` Thomas Lamprecht
2021-10-11 13:30       ` Dominik Csapak
2021-10-11 13:37         ` Thomas Lamprecht
2021-10-11 13:57           ` Dominik Csapak
2021-10-12  5:33             ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=637c31e5-7c5b-065a-811d-ccd54eeaaa1b@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal