From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH common/access-control/wt/manager v3] add realm sync jobs
Date: Wed, 7 Jun 2023 11:59:06 +0200 [thread overview]
Message-ID: <6355f3b1-8729-8573-eb62-050e98f6d67f@proxmox.com> (raw)
In-Reply-To: <20230117114659.2397499-1-d.csapak@proxmox.com>
Am 17/01/2023 um 12:46 schrieb Dominik Csapak:
> pve-manager:
>
> Dominik Csapak (4):
> Jobs: include existing types in state file regex for deletion
> Jobs: add RealmSync Plugin and register it
> api: add realm-sync crud api to /cluster/jobs
> ui: add Realm Sync panel
>
> PVE/API2/Cluster/Jobs.pm | 7 +
> PVE/Jobs.pm | 7 +-
> www/manager6/Makefile | 1 +
> www/manager6/dc/Config.js | 7 +
> www/manager6/dc/RealmSyncJob.js | 364 ++++++++++++++++++++++++++++++++
> 5 files changed, 385 insertions(+), 1 deletion(-)
> create mode 100644 www/manager6/dc/RealmSyncJob.js
>
Now applied those too finally, thanks!
Some thoughts:
* would clarify that a existing LDAP/AD realm is required via some UX change in the
add/edit widnow, maybe:
- add an empty text in the field
- disable the "scope" field until an realm is selected, as otherwise the invalid
state is slightly confusing.
* Merge this into realm, as panel at the bottom there.
Having many realms is rather the exception, the two built-ins plus one or maybe
two external ones (e.g., a LDAP and a OIDC) are probably enough for most setups.
That means we got a lot of "free" reals^W space estate in the existing realm panel,
putting that to better use and avoiding a tree entry might maybe improve cognitive
load imposed by our UI minimally (or at least not increase it).
* A "Run now" button is missing?
prev parent reply other threads:[~2023-06-07 9:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 11:46 Dominik Csapak
2023-01-17 11:46 ` [pve-devel] [PATCH common v3 1/1] SectionConfig: add helper to delete keys from a section config entry Dominik Csapak
2023-03-08 6:53 ` Thomas Lamprecht
2023-03-11 17:23 ` [pve-devel] applied: " Thomas Lamprecht
2023-01-17 11:46 ` [pve-devel] [PATCH access-control v3 1/2] realm sync: refactor scope/remove-vanished into a standard option Dominik Csapak
2023-03-08 11:43 ` [pve-devel] applied: " Thomas Lamprecht
2023-01-17 11:46 ` [pve-devel] [PATCH access-control v3 2/2] add realm-sync plugin for jobs and CRUD api for realm-sync-jobs Dominik Csapak
2023-06-07 8:38 ` [pve-devel] applied: " Thomas Lamprecht
2023-01-17 11:46 ` [pve-devel] [PATCH widget-toolkit v3 1/1] RealmComboBox: add custom store filters for callers Dominik Csapak
2023-03-14 14:26 ` [pve-devel] applied: " Thomas Lamprecht
2023-01-17 11:46 ` [pve-devel] [PATCH manager v3 1/4] Jobs: include existing types in state file regex for deletion Dominik Csapak
2023-01-17 11:46 ` [pve-devel] [PATCH manager v3 2/4] Jobs: add RealmSync Plugin and register it Dominik Csapak
2023-01-17 11:46 ` [pve-devel] [PATCH manager v3 3/4] api: add realm-sync crud api to /cluster/jobs Dominik Csapak
2023-01-17 11:46 ` [pve-devel] [PATCH manager v3 4/4] ui: add Realm Sync panel Dominik Csapak
2023-03-07 8:06 ` [pve-devel] [PATCH common/access-control/wt/manager v3] add realm sync jobs Dominik Csapak
2023-05-03 7:35 ` Dominik Csapak
2023-06-07 9:59 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6355f3b1-8729-8573-eb62-050e98f6d67f@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.