From: Gabriel Goller <g.goller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox] fix #4162: sys: added `auto-submitted` header to email body
Date: Fri, 8 Sep 2023 15:07:16 +0200 [thread overview]
Message-ID: <6248308c-0fa6-34c4-0845-e0e4523a3f08@proxmox.com> (raw)
In-Reply-To: <528d4cc8-c361-412a-ad22-497118bbd550@proxmox.com>
Sent a new patch version.
On 9/7/23 17:42, Thomas Lamprecht wrote:
> On 28/08/2023 10:44, Gabriel Goller wrote:
>> `Auto-Submitted` is defined in the rfc 5436 [1] and describes how
>> an automatic response (f.e. ooo replies, etc.) should behave on the
>> emails. When using `Auto-Submitted: auto-generated` (or any value
>> other than `none`) automatic replies won't be triggered.
>>
>> [1]: https://www.rfc-editor.org/rfc/rfc3834.html
>>
>> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
>> ---
>> proxmox-sys/src/email.rs | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/proxmox-sys/src/email.rs b/proxmox-sys/src/email.rs
>> index da910d4..9f53718 100644
>> --- a/proxmox-sys/src/email.rs
>> +++ b/proxmox-sys/src/email.rs
>> @@ -81,6 +81,7 @@ pub fn sendmail(
> Please add the fact that this is always for auto-generated mails to the
> doc comment, so that anybody that wants to use this for something where
> a human actually writes/sends the mail is aware of this behavior.
>
>> }
>> if let Some(html) = html {
> why only add this to mails that include HTML, but not pure plain text ones?
> Didn't see anything in the RFC that would indicate it should be done this
> way, or did I overlook that part?
>
>> body.push_str("Content-Type: text/html;\n");
>> + body.push_str("Auto-Submitted: auto-generated;\n");
>> body.push_str("\tcharset=\"UTF-8\"\n");
>> body.push_str("Content-Transfer-Encoding: 8bit\n");
>> body.push('\n');
prev parent reply other threads:[~2023-09-08 13:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 8:44 Gabriel Goller
2023-09-07 15:42 ` Thomas Lamprecht
2023-09-08 13:07 ` Gabriel Goller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6248308c-0fa6-34c4-0845-e0e4523a3f08@proxmox.com \
--to=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.