From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: [pve-devel] applied: [PATCH access-control] fix realm sync permissions
Date: Mon, 20 Dec 2021 20:44:52 +0100 [thread overview]
Message-ID: <611f81bb-e51a-16a3-6b4e-6a45f8cbc386@proxmox.com> (raw)
In-Reply-To: <20211220103115.146070-1-w.bumiller@proxmox.com>
On 20/12/2021 11:31, Wolfgang Bumiller wrote:
> The userid-* permission check variants work on
> $param->{userid} directly which does not exist for this
> call. Also, they work on the realm of the user being
> checked, rather than the realm provided as parameter.
>
> The result was that as non-root user this always failed
> with the message "userid '' too short"
>
> Fix this by making the check explicitly work like in the
> description.
>
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
> src/PVE/API2/Domains.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2021-12-20 19:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 10:31 [pve-devel] " Wolfgang Bumiller
2021-12-20 19:44 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=611f81bb-e51a-16a3-6b4e-6a45f8cbc386@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal