Re: [pbs-devel] [PATCH proxmox 1/3] time: Add traits to DateTimeValue and TimeSpec

[Dominik Csapak <d.csapak@proxmox.com>]

On 8/13/25 13:29, Maximiliano Sandoval wrote:
> Dominik Csapak <d.csapak@proxmox.com> writes:
> 
>> On 8/13/25 13:26, Maximiliano Sandoval wrote:
>>> Maximiliano Sandoval <m.sandoval@proxmox.com> writes:
>>>
>>>> which are useful for tests.
>>>>
>>>> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
>>>> ---
>>>>    proxmox-time/src/calendar_event.rs  | 1 +
>>>>    proxmox-time/src/date_time_value.rs | 2 +-
>>>>    2 files changed, 2 insertions(+), 1 deletion(-)
>>> In a support case we found a system with 40:00 as a schedule in a backup
>>> job. It is possible to entire this calendar event on the web UI.
>>> After this series the web UI won't allow it anymore with an error:
>>> ```
>>> Parameter verification failed. (400)
>>> schedule: invalid format - invalid calendar event '40:00' - unable to parse
>>> calendar event at ':00' - Nom(Eof)
>>> ```
>>>
>>
>> but that is a valid calendar spec? it just means something different than what
>> the user expected ? (every hour at minute 40)
> 
> At least systemd-analyze does not like it:
> 
> ```
> systemd-analyze calendar 40:00
> Failed to parse calendar specification '40:00': Invalid argument
> ```
> 

ok fair point


> I would hope that 20:00 is no different than 40:00 (e.g. the first
> component refers to hours). Is the "calendar spec" defined somewhere?
> 


we have this:
https://pbs.proxmox.com/docs/calendarevents.html

which actually supports your change (hours not optional in the timespec)

i just fear that some people already have configures such jobs that will 
not run anymore after this change?


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel