From: Robert Obkircher <r.obkircher@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: Re: [PATCH datacenter-manager] api: network: drop superfluous clippy attribute
Date: Mon, 28 Sep 2026 11:10:17 +0200 [thread overview]
Message-ID: <61047ba7-9233-4ad0-9b66-0a02b7c64ddb@proxmox.com> (raw)
In-Reply-To: <20260925093452.506424-1-c.heiss@proxmox.com>
On 25.09.26 11:40, Christoph Heiss wrote:
> Probably a leftover from copy-paste. Does nothing here, as the function
> only has two parameters anyway.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> server/src/api/nodes/network.rs | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/server/src/api/nodes/network.rs b/server/src/api/nodes/network.rs
> index 3b97f970..67720424 100644
> --- a/server/src/api/nodes/network.rs
> +++ b/server/src/api/nodes/network.rs
> @@ -110,7 +110,6 @@ pub fn read_interface(iface: String, rpcenv: &mut dyn RpcEnvironment) -> Result<
> },
> )]
> /// Create network interface configuration.
> -#[allow(clippy::too_many_arguments)]
> pub fn create_interface(iface: String, config: InterfaceUpdater) -> Result<(), Error> {
> proxmox_network_api::create_interface(iface, config)
> }
(We should start using the #[expect(..)] attribute to prevent similar
issues in the future)
prev parent reply other threads:[~2026-09-28 9:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 9:34 [PATCH datacenter-manager] api: network: drop superfluous clippy attribute Christoph Heiss
2026-09-28 9:10 ` Robert Obkircher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61047ba7-9233-4ad0-9b66-0a02b7c64ddb@proxmox.com \
--to=r.obkircher@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.