From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id EE2E41FF09B for ; Mon, 28 Sep 2026 11:10:25 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D80B0216A6; Mon, 28 Sep 2026 11:10:14 +0200 (CEST) Message-ID: <61047ba7-9233-4ad0-9b66-0a02b7c64ddb@proxmox.com> Date: Mon, 28 Sep 2026 11:10:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH datacenter-manager] api: network: drop superfluous clippy attribute To: pdm-devel@lists.proxmox.com References: <20260925093452.506424-1-c.heiss@proxmox.com> Content-Language: en-US, de-AT From: Robert Obkircher In-Reply-To: <20260925093452.506424-1-c.heiss@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1790586618018 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.524 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: X6NI6JSK6VVQJ52HPT46NBGEBCITIJWH X-Message-ID-Hash: X6NI6JSK6VVQJ52HPT46NBGEBCITIJWH X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 25.09.26 11:40, Christoph Heiss wrote: > Probably a leftover from copy-paste. Does nothing here, as the function > only has two parameters anyway. > > Signed-off-by: Christoph Heiss > --- > server/src/api/nodes/network.rs | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/server/src/api/nodes/network.rs b/server/src/api/nodes/network.rs > index 3b97f970..67720424 100644 > --- a/server/src/api/nodes/network.rs > +++ b/server/src/api/nodes/network.rs > @@ -110,7 +110,6 @@ pub fn read_interface(iface: String, rpcenv: &mut dyn RpcEnvironment) -> Result< > }, > )] > /// Create network interface configuration. > -#[allow(clippy::too_many_arguments)] > pub fn create_interface(iface: String, config: InterfaceUpdater) -> Result<(), Error> { > proxmox_network_api::create_interface(iface, config) > } (We should start using the #[expect(..)] attribute to prevent similar issues in the future)