Re: [pve-devel] [PATCH docs] passthrough: viommu: remove 'amd_iommu=on' from the docs

[Dominik Csapak <d.csapak@proxmox.com>]

On 7/24/24 11:59, Fiona Ebner wrote:
> Am 26.04.24 um 09:58 schrieb Dominik Csapak:
>> this is wrong and does nothing, see previous commit:
>> 0c54d61 (remove 'amd_iommu=on' from the passthrough docs)
>> and
>> https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html?highlight=amd_iommu
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>>   qm-pci-passthrough.adoc | 3 +--
>>   1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc
>> index bbd6b85..14f7fa5 100644
>> --- a/qm-pci-passthrough.adoc
>> +++ b/qm-pci-passthrough.adoc
>> @@ -511,8 +511,7 @@ There are currently two vIOMMU implementations available: Intel and VirtIO.
>>   
>>   Host requirement:
>>   
>> -* Add `intel_iommu=on` or `amd_iommu=on` depending on your CPU to your kernel
>> -command line.
>> +* Add `intel_iommu=on` depending on your CPU to your kernel command line.
>>   
> 
> IMHO saying "For Intel CPUs, add ..." sounds nicer than "add ...
> depending on your CPU" together with your change. And we could also
> mention that it's only required for kernels before 6.8 and nothing for
> AMD CPUs?

Makes sense, but i'd probably leave the kernel version part out,
since that changed in the kernel a few times already (and activating it
if it's default shouldn't hurt much)

Long term i'd like to make that a gui feature anyway where
we automatically do the right thing

> 
>>   Intel vIOMMU
>>   ^^^^^^^^^^^^



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel