Re: [pbs-devel] [PATCH proxmox-backup 1/2] api: create default prune job on datastore creation

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 29/11/2023 um 14:27 schrieb Fabian Grünbichler:
> On November 29, 2023 12:36 pm, Christian Ebner wrote:
>> Create a default prune job when a datastore is created as part of a
>> disk/zpool creation transaction via e.g.:
>> `proxmox-backup-manager disk fs create <storage-name> --disk <block-device>
>> --add-datastore true`
> is this documented anywhere?
> 
> `proxmox-backup-manager datastore create ..` does not add any
> schedules/jobs by default, it's just the web UI that does (but that also
> tells you about this, and allows you to override it!)
> 
> I agree that it probably makes sense, but it should be consistent
> - web UI does it, but then it should display it (and it would need to
>   become a new optional parameter here, maybe by extending
>   "add_datastore", else overriding would not be possible)
> - proxmox-backup-manager does it, but then it should also do it for a
>   "plain" datastore creation by default?

yeah, API might be indeed odd, especially if it happens unconditionally.

It might be better in general to add a hint to the UI (e.g., the datastore
summary) if there's no prune job and/or no garbage-collection schedule.