[PATCH qemu-server] cpu models: only include custom models on x86_64

[PATCH qemu-server] cpu models: only include custom models on x86_64

[Arthur Bied-Charreton]

The custom CPU models config does not currently expose a way to specify
an arch and it defaults to x86_64.

Only include custom models if $arch is set to x86_64 to prevent listing
x86_64-only custom models in the CPU model selector for arm VMs.

Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
---
 src/PVE/QemuServer/CPUConfig.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/PVE/QemuServer/CPUConfig.pm b/src/PVE/QemuServer/CPUConfig.pm
index 10f7729d..b037a34e 100644
--- a/src/PVE/QemuServer/CPUConfig.pm
+++ b/src/PVE/QemuServer/CPUConfig.pm
@@ -572,6 +572,8 @@ sub add_cpu_json_properties($prop) {
 
 sub get_cpu_models($include_custom, $arch = undef) {
     $arch //= get_host_arch();
+    $include_custom = 0 if $arch ne 'x86_64';
+
     my $cpu_vendor_list = get_cpu_models_by_arch($arch);
 
     my $models = [];
-- 
2.47.3

Re: [PATCH qemu-server] cpu models: only include custom models on x86_64

[Fiona Ebner]

Am 19.05.26 um 9:51 AM schrieb Arthur Bied-Charreton:
> The custom CPU models config does not currently expose a way to specify
> an arch and it defaults to x86_64.
> 

This is not true? It implicitly defaults to the arch of the base model
(i.e. reported-model) and custom models for aarch64 can be created and
used just fine. Just not created via UI.


> Only include custom models if $arch is set to x86_64 to prevent listing
> x86_64-only custom models in the CPU model selector for arm VMs.
> 
> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>

We should rather filter out the models where the base model does not fit
the arch.

Re: [PATCH qemu-server] cpu models: only include custom models on x86_64

[Fiona Ebner]

Am 19.05.26 um 10:13 AM schrieb Fiona Ebner:
> Am 19.05.26 um 9:51 AM schrieb Arthur Bied-Charreton:
>> The custom CPU models config does not currently expose a way to specify
>> an arch and it defaults to x86_64.
>>
> 
> This is not true? It implicitly defaults to the arch of the base model
> (i.e. reported-model) and custom models for aarch64 can be created and
> used just fine. Just not created via UI.
> 

Also, if the host itself is ARM, then they can also be created via UI,
right?

> 
>> Only include custom models if $arch is set to x86_64 to prevent listing
>> x86_64-only custom models in the CPU model selector for arm VMs.
>>
>> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> 
> We should rather filter out the models where the base model does not fit
> the arch.
> 
> 
> 
> 

Re: [PATCH qemu-server] cpu models: only include custom models on x86_64

[Arthur Bied-Charreton]

On Tue, May 19, 2026 at 10:17:49AM +0200, Fiona Ebner wrote:
> Am 19.05.26 um 10:13 AM schrieb Fiona Ebner:
> > Am 19.05.26 um 9:51 AM schrieb Arthur Bied-Charreton:
> >> The custom CPU models config does not currently expose a way to specify
> >> an arch and it defaults to x86_64.
> >>
> > 
> > This is not true? It implicitly defaults to the arch of the base model
> > (i.e. reported-model) and custom models for aarch64 can be created and
> > used just fine. Just not created via UI.
> > 
> 
> Also, if the host itself is ARM, then they can also be created via UI,
> right?
> 
Yes, we do not pass any arch parameter to the 
nodes/.../capabilities/qemu/cpu endpoint in the custom model editor 
so the list defaults to the host arch. Thanks for correcting this.
> > 
> >> Only include custom models if $arch is set to x86_64 to prevent listing
> >> x86_64-only custom models in the CPU model selector for arm VMs.
> >>
> >> Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> > 
> > We should rather filter out the models where the base model does not fit
> > the arch.
> > 

Re: [PATCH qemu-server] cpu models: only include custom models on x86_64

[Arthur Bied-Charreton]

On Tue, May 19, 2026 at 10:13:47AM +0200, Fiona Ebner wrote:
> Am 19.05.26 um 9:51 AM schrieb Arthur Bied-Charreton:
> > The custom CPU models config does not currently expose a way to specify
> > an arch and it defaults to x86_64.
> > 
> 
> This is not true? It implicitly defaults to the arch of the base model
> (i.e. reported-model) and custom models for aarch64 can be created and
> used just fine. Just not created via UI.
> 
Argh you're right, I misremembered that
> 
> > Only include custom models if $arch is set to x86_64 to prevent listing
> > x86_64-only custom models in the CPU model selector for arm VMs.
> > 
> > Signed-off-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
> 
> We should rather filter out the models where the base model does not fit
> the arch.
makes sense, will rather do that

superseded: [PATCH qemu-server] cpu models: only include custom models on x86_64

[Arthur Bied-Charreton]

Superseded-by:
https://lore.proxmox.com/pve-devel/20260519090423.224307-1-a.bied-charreton@proxmox.com/