From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Matthias Heiserer <m.heiserer@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 manager 1/2] GUI: HDEdit: check iothread by default
Date: Tue, 10 May 2022 09:26:53 +0200 [thread overview]
Message-ID: <5f9c610d-3e45-c502-b305-8be4bf33e8fc@proxmox.com> (raw)
In-Reply-To: <20220428084449.144884-1-m.heiserer@proxmox.com>
Am 28.04.22 um 10:44 schrieb Matthias Heiserer:
> And move it from the advanced section to the always shown area.
>
> Because of the propertyStringSet call in onGetValues, existing VM
> show the correct iothread value.
>
> Especially in benchmarks, iothreads significantly improve IO performance.
>
It's checked in the creation wizard, but (at least for me) not when
adding a new disk afterwards, which is unexpected.
Can we figure out the controller type here (maybe by passing along from
the parent component)? Then we could auto-select depending on the
controller type and maybe even display a quick note if there's mismatch.
As currently, people selecting an incompatible controller type will
still get the checkbox ticked automatically.
prev parent reply other threads:[~2022-05-10 7:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 8:44 Matthias Heiserer
2022-04-28 8:44 ` [pve-devel] [PATCH v2 manager 2/2] GUI: OS defaults: use SCSI single as default controller Matthias Heiserer
2022-04-28 8:44 ` [pve-devel] [PATCH v2 qemu-server 1/1] Warn in GUI for unlikely iothread config Matthias Heiserer
2022-05-10 7:26 ` Fabian Ebner
2022-05-10 7:33 ` Fabian Ebner
2022-05-09 15:13 ` [pve-devel] [PATCH v2 manager 1/2] GUI: HDEdit: check iothread by default Daniel Tschlatscher
2022-05-10 7:26 ` Fabian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f9c610d-3e45-c502-b305-8be4bf33e8fc@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.