Re: [pve-devel] [PATCH close #545, #5203: Allow bridges to have any valid interface name 0/2]

[Stefan Hanreich <s.hanreich@proxmox.com>]

Hi!

Thanks for your patch! In general we like the idea of being able to
choose arbitrary names for bridges - but there's some additional things
to consider before we can apply those patches.

We are currently using prefixes for other types of interfaces as well.
With this patch series I could create bridges named 'bondX' which are
then picked up as a bond by the Web UI since the check for that in
INotify.pm is located before the check for bridges.
It would be a bit weird to name a bridge with the prefix bond
admittedly, but we should try to handle this more gracefully (iow. check
first whether an entry is a bridge and only then check for the other cases)

It might make sense to check for any possible conflicts with the SDN
config (running & staged).

I've added some additional comments inline - I can look into a v2
addressing those issues.

On 1/26/24 18:17, Jillian Morgan wrote:
> Allow bridges to have any valid interface name
> 
> The patches are 1-line each, but across two repositories:
>   proxmox-widget-toolkit (Toolkit.js)
>   pve-common (INotify.pm)
> 
> Jillian Morgan (2):
>   Allow bridges to have any valid interface name
>   Detect bridge interface by bridge_ports attribute
> 
>  src/Toolkit.js | 2 +-
>  src/PVE/INotify.pm | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
>