* [pbs-devel] [PATCH proxmox-backup] sync: fix recursive remote sync
@ 2023-11-30 10:42 Fabian Grünbichler
2023-11-30 10:57 ` [pbs-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Grünbichler @ 2023-11-30 10:42 UTC (permalink / raw)
To: pbs-devel
the snapshot pulling code always selected the "top" namespace of the source,
instead of the passed in namespace parameter.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
src/server/pull.rs | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/server/pull.rs b/src/server/pull.rs
index 66ef333a..44d428fd 100644
--- a/src/server/pull.rs
+++ b/src/server/pull.rs
@@ -187,7 +187,7 @@ impl PullSource for RemoteSource {
async fn list_backup_dirs(
&self,
- _namespace: &BackupNamespace,
+ namespace: &BackupNamespace,
group: &BackupGroup,
worker: &WorkerTask,
) -> Result<Vec<BackupDir>, Error> {
@@ -198,8 +198,8 @@ impl PullSource for RemoteSource {
"backup-id": group.id,
});
- if !self.ns.is_root() {
- args["ns"] = serde_json::to_value(&self.ns)?;
+ if !namespace.is_root() {
+ args["ns"] = serde_json::to_value(&namespace)?;
}
self.client.login().await?;
--
2.39.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pbs-devel] applied: [PATCH proxmox-backup] sync: fix recursive remote sync
2023-11-30 10:42 [pbs-devel] [PATCH proxmox-backup] sync: fix recursive remote sync Fabian Grünbichler
@ 2023-11-30 10:57 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-11-30 10:57 UTC (permalink / raw)
To: Proxmox Backup Server development discussion, Fabian Grünbichler
Am 30/11/2023 um 11:42 schrieb Fabian Grünbichler:
> the snapshot pulling code always selected the "top" namespace of the source,
> instead of the passed in namespace parameter.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> src/server/pull.rs | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
applied, with Dominik's off-list provided R-b/T-b trailers, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-30 10:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-30 10:42 [pbs-devel] [PATCH proxmox-backup] sync: fix recursive remote sync Fabian Grünbichler
2023-11-30 10:57 ` [pbs-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal