Re: applied: [PATCH pve-manager v2 0/1] fix: #4490 ui: backup job window: add search for virtual guest grid

[David Riley <d.riley@proxmox.com>]

Thanks, I will have a look at it.

On 5/13/26 2:32 AM, Thomas Lamprecht wrote:
> On Fri, 27 Mar 2026 11:38:00 +0100, David Riley wrote:
>> This v2 implements the suggested stop-gap solution for filtering the
>> virtual guest selection in the backup job edit window.
>>
>> Differences from v1:
>> - Drop the complex collapsible filter panel (tags, pools, HA State)
>>    This avoids the UX trap of users thinking the filters apply
>>    dynamically at job runtime (deferring that feature for a proper
>>    implementation of #4186 [0]).
>> - Add search text-field in the grid toolbar to filter by
>>    Name or VMID.
>> - Add a "Review" toggle checkbox in the bottom toolbar that limits
>>    the grid view to only currently selected guests.
>> - Add a "Selected (X)" counter in the bottom toolbar for immediate
>>    visual feedback.
>> - Override the `getValue` collection logic to gather data directly
>>    from the SelectionModel, ensuring virtual guests hidden by the
>>    Search filter are still correctly submitted.
>>
>> [...]
> Applied, thanks! FYI: I factored the now ~three time existing search widget out
> into a common module in a follow-up and did some minor adaptions.
>
> [1/1] fix: #4490 ui: backup job window: add search for virtual guest grid
>        commit: 7ad74616a0b7bd5f8999a28f429963980298f9e9