From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 652201FF13A for ; Wed, 13 May 2026 08:45:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 55D5037613; Wed, 13 May 2026 08:45:12 +0200 (CEST) Message-ID: <5edd5bb0-7fbd-42a6-81c5-1f74f9badbb4@proxmox.com> Date: Wed, 13 May 2026 08:44:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: applied: [PATCH pve-manager v2 0/1] fix: #4490 ui: backup job window: add search for virtual guest grid To: Thomas Lamprecht , pve-devel@lists.proxmox.com References: <20260327103801.104735-1-d.riley@proxmox.com> <177863242554.3618550.18412291321944223153.b4-ty@b4> Content-Language: en-US From: David Riley In-Reply-To: <177863242554.3618550.18412291321944223153.b4-ty@b4> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778654564315 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.320 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZRS63DGYERCPTAFQ7LGY7VI7ULT3TPP5 X-Message-ID-Hash: ZRS63DGYERCPTAFQ7LGY7VI7ULT3TPP5 X-MailFrom: d.riley@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks, I will have a look at it. On 5/13/26 2:32 AM, Thomas Lamprecht wrote: > On Fri, 27 Mar 2026 11:38:00 +0100, David Riley wrote: >> This v2 implements the suggested stop-gap solution for filtering the >> virtual guest selection in the backup job edit window. >> >> Differences from v1: >> - Drop the complex collapsible filter panel (tags, pools, HA State) >> This avoids the UX trap of users thinking the filters apply >> dynamically at job runtime (deferring that feature for a proper >> implementation of #4186 [0]). >> - Add search text-field in the grid toolbar to filter by >> Name or VMID. >> - Add a "Review" toggle checkbox in the bottom toolbar that limits >> the grid view to only currently selected guests. >> - Add a "Selected (X)" counter in the bottom toolbar for immediate >> visual feedback. >> - Override the `getValue` collection logic to gather data directly >> from the SelectionModel, ensuring virtual guests hidden by the >> Search filter are still correctly submitted. >> >> [...] > Applied, thanks! FYI: I factored the now ~three time existing search widget out > into a common module in a follow-up and did some minor adaptions. > > [1/1] fix: #4490 ui: backup job window: add search for virtual guest grid > commit: 7ad74616a0b7bd5f8999a28f429963980298f9e9