Re: [pve-devel] [PATCH manager] fix #4631: ceph: osd: create: add osds-per-device

[Fiona Ebner <f.ebner@proxmox.com>]

Am 21.08.23 um 12:51 schrieb Aaron Lauterer:
> responses inline
> 

Feel free to cut away irrelevant bits when responding (could've cut away
the commit message myself last time already) ;)

> On 8/21/23 10:20, Fiona Ebner wrote:
>> I noticed a warning while testing
>>
>> --> DEPRECATION NOTICE
>> --> You are using the legacy automatic disk sorting behavior
>> --> The Pacific release will change the default to --no-auto
>> --> passed data devices: 1 physical, 0 LVM
>> --> relative data size: 0.3333333333333333
>>
>> Note that I'm on Quincy, so maybe they didn't still didn't change it :P
> 
> Also shows up when using `ceph-volume lvm batch …` directly. So I guess
> not much we can do about it after consulting the man page.

We could explicitly pass --no-auto I guess [0]? While it doesn't make a
difference, since we only pass one disk to 'batch', it would at least
avoid the warning.

[0]: https://docs.ceph.com/en/reef/ceph-volume/lvm/batch/

>>
>>> +        minimum => '1',
>>> +        description => 'OSD services per physical device. Can
>>> improve fast NVME utilization.',
>>
>> Can we add an explicit recommendation against doing it for other disk
>> types? I imagine it's not beneficial for those, or?
> 
> What about something like:
> "Only useful for fast NVME devices to utilize their performance better."?
> 

Sounds good to me.

>>
>>> +        },
>>>       },
>>>       },
>>>       returns => { type => 'string' },
>>> @@ -294,6 +300,15 @@ __PACKAGE__->register_method ({
>>>       # extract parameter info and fail if a device is set more than
>>> once
>>>       my $devs = {};
>>>   +    # allow 'osds-per-device' only without dedicated db and/or wal
>>> devs. We cannot specify them with
>>> +    # 'ceph-volume lvm batch' and they don't make a lot of sense on
>>> fast NVMEs anyway.
>>> +    if ($param->{'osds-per-device'}) {
>>> +        for my $type ( qw(db_dev wal_dev) ) {
>>> +        die "Cannot use 'osds-per-device' parameter with '${type}'"
>>
>> Missing newline after error message.
>> Could also use raise_param_exc().
> 
> Ah thanks. Will switch it to an `raise_param_exc()` where we don't need
> the newline AFAICT?

Yes, the function will add a newline.