From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: [pve-devel] applied: [PATCH common] tools: use int() on all integer syscall parameters
Date: Fri, 20 May 2022 15:16:43 +0200 [thread overview]
Message-ID: <5e49b756-94fa-153b-b005-303f22e72fac@proxmox.com> (raw)
In-Reply-To: <20220517124003.317063-1-w.bumiller@proxmox.com>
On 17/05/2022 14:40, Wolfgang Bumiller wrote:
> this should fix an issue where users with custom id mappings
> get bad ownership on intermediate directories caused by the
> rootuid/gid being the string "100000" in perl instead of the
> number 100000...
>
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
> NOTE: I decided to go through them all, not just `fchownat` which was
> currently problematic (most likely the issue of [1]).
>
> I hope I got them all right.
>
> This was a frustrating one.
>
> pve needs more rust...
+1
>
> [1] https://forum.proxmox.com/threads/restoring-lxc-from-pbs-fails.108905/#post-471509
>
> src/PVE/Tools.pm | 91 ++++++++++++++++++++++++++++++++++--------------
> 1 file changed, 65 insertions(+), 26 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2022-05-20 13:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 12:40 [pve-devel] " Wolfgang Bumiller
2022-05-20 13:16 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e49b756-94fa-153b-b005-303f22e72fac@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.