From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-ldap 0/6] introduce proxmox-ldap crate
Date: Tue, 24 Jan 2023 08:04:02 +0100 [thread overview]
Message-ID: <5e25c8e9-606a-7121-7daa-ad06914fe553@proxmox.com> (raw)
In-Reply-To: <a3af99a1-ea5f-b309-f059-117333fdc3f2@proxmox.com>
Am 23/01/2023 um 15:50 schrieb Lukas Wagner:
> Thanks for the review.
>
> On 1/23/23 12:27, Thomas Lamprecht wrote:
>> Can you please sent a v3 that bases is on that repo and has Wolfgang's minor
>> comments addressed?
>
> Sure!
> Since this series was a spin-off from my original LDAP series which *also* affected the `proxmox` repo
> in v2 as well: Should I merge both series for a common v3? Or should I keep them separate
> to keep the patch series a bit smaller/more manageable? What would you prefer?
>
Separate is fine, as the crates in proxmox are all stand alone.
IMO the series separation was a good call, and merging the two series
due to them touching (partially) the same repos is not the best criteria,
at least on its own.
prev parent reply other threads:[~2023-01-24 7:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 14:20 Lukas Wagner
2023-01-17 14:20 ` [pbs-devel] [PATCH proxmox-ldap 1/6] initial commit Lukas Wagner
2023-01-17 14:20 ` [pbs-devel] [PATCH proxmox-ldap 2/6] add basic user auth functionality Lukas Wagner
2023-01-17 14:20 ` [pbs-devel] [PATCH proxmox-ldap 3/6] add helpers for constructing LDAP filters Lukas Wagner
2023-01-18 12:21 ` Wolfgang Bumiller
2023-01-17 14:20 ` [pbs-devel] [PATCH proxmox-ldap 4/6] allow searching for LDAP entities Lukas Wagner
2023-01-17 14:20 ` [pbs-devel] [PATCH proxmox-ldap 5/6] tests: add LDAP integration tests Lukas Wagner
2023-01-17 14:20 ` [pbs-devel] [PATCH proxmox-ldap 6/6] add debian packaging Lukas Wagner
2023-01-18 12:30 ` [pbs-devel] [PATCH proxmox-ldap 0/6] introduce proxmox-ldap crate Wolfgang Bumiller
2023-01-23 11:27 ` Thomas Lamprecht
2023-01-23 14:50 ` Lukas Wagner
2023-01-24 7:04 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e25c8e9-606a-7121-7daa-ad06914fe553@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.