[PATCH proxmox-backup v2 0/1] fix #7412: ui: dashboard: persist datastore usage column state

[PATCH proxmox-backup v2 0/1] fix #7412: ui: dashboard: persist datastore usage column state

[David Riley]

Thanks for the review and for testing. 

Differences from v1:
* renamed the `stateId` to match the naming conventions of pbs
* Carried over the `Fixes`, `Reviewed-by` and `Tested-by` trailers.

David Riley (1):
  fix #7412: ui: dashboard: persist datastore usage column state

 www/dashboard/DataStoreStatistics.js | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.47.3

[PATCH proxmox-backup v2 1/1] fix #7412: ui: dashboard: persist datastore usage column state

[David Riley]

Store the state of the columns for the Datastore Usage Dashboard.
Ensures the column configuration is maintained across
page reloads and navigations instead of resetting to the default view.

Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=7412
Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>
Signed-off-by: David Riley <d.riley@proxmox.com>
---
 www/dashboard/DataStoreStatistics.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/dashboard/DataStoreStatistics.js b/www/dashboard/DataStoreStatistics.js
index c210d24d..1d38d1f2 100644
--- a/www/dashboard/DataStoreStatistics.js
+++ b/www/dashboard/DataStoreStatistics.js
@@ -55,6 +55,8 @@ Ext.define('PBS.DatastoreStatistics', {
 
     title: gettext('Datastore Usage'),
     disableSelection: true,
+    stateful: true,
+    stateId: 'grid-datastore-statistics',
 
     emptyText: gettext('No Data'),
 
-- 
2.47.3

Re: [PATCH proxmox-backup v2 0/1] fix #7412: ui: dashboard: persist datastore usage column state

[Dominik Csapak]

hi,

just a small nit:

usually if a single patch is sent, there is no need for a cover letter,
and the comments and changelog can be written below the first  '---' 
part of the patch

if it's there it will not end up in the git log

On 3/26/26 2:19 PM, David Riley wrote:
> Thanks for the review and for testing.
> 
> Differences from v1:
> * renamed the `stateId` to match the naming conventions of pbs
> * Carried over the `Fixes`, `Reviewed-by` and `Tested-by` trailers.
> 
> David Riley (1):
>    fix #7412: ui: dashboard: persist datastore usage column state
> 
>   www/dashboard/DataStoreStatistics.js | 2 ++
>   1 file changed, 2 insertions(+)
>