From: Dominik Csapak <d.csapak@proxmox.com>
To: David Riley <d.riley@proxmox.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-backup v2 0/1] fix #7412: ui: dashboard: persist datastore usage column state
Date: Fri, 27 Mar 2026 11:05:12 +0100 [thread overview]
Message-ID: <5e16343c-c0fc-4e46-b1b1-9b6e62bbd1ba@proxmox.com> (raw)
In-Reply-To: <20260326131837.28941-1-d.riley@proxmox.com>
hi,
just a small nit:
usually if a single patch is sent, there is no need for a cover letter,
and the comments and changelog can be written below the first '---'
part of the patch
if it's there it will not end up in the git log
On 3/26/26 2:19 PM, David Riley wrote:
> Thanks for the review and for testing.
>
> Differences from v1:
> * renamed the `stateId` to match the naming conventions of pbs
> * Carried over the `Fixes`, `Reviewed-by` and `Tested-by` trailers.
>
> David Riley (1):
> fix #7412: ui: dashboard: persist datastore usage column state
>
> www/dashboard/DataStoreStatistics.js | 2 ++
> 1 file changed, 2 insertions(+)
>
prev parent reply other threads:[~2026-03-27 10:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 13:18 David Riley
2026-03-26 13:18 ` [PATCH proxmox-backup v2 1/1] " David Riley
2026-03-27 10:05 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e16343c-c0fc-4e46-b1b1-9b6e62bbd1ba@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=d.riley@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.