* [pve-devel] [PATCH qemu] fix typos in user-visible strings
@ 2024-10-08 15:14 Maximiliano Sandoval
2024-10-24 11:21 ` [pve-devel] applied: " Fiona Ebner
0 siblings, 1 reply; 2+ messages in thread
From: Maximiliano Sandoval @ 2024-10-08 15:14 UTC (permalink / raw)
To: pve-devel
This includes docs, and strings printed to stderr or stdout.
These were caught with:
typos --exclude test --exclude changelog
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
PVE/API2/Qemu.pm | 14 +++++++-------
PVE/CLI/qm.pm | 4 ++--
PVE/QMPClient.pm | 6 +++---
PVE/QemuServer.pm | 10 +++++-----
PVE/QemuServer/OVF.pm | 4 ++--
PVE/QemuServer/PCI.pm | 2 +-
PVE/QemuServer/USB.pm | 2 +-
7 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index d25a79fe..848001b6 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -801,7 +801,7 @@ __PACKAGE__->register_method({
method => 'GET',
description => "Virtual machine index (per node).",
permissions => {
- description => "Only list VMs where you have VM.Audit permissons on /vms/<vmid>.",
+ description => "Only list VMs where you have VM.Audit permissions on /vms/<vmid>.",
user => 'all',
},
proxyto => 'node',
@@ -1795,7 +1795,7 @@ my $update_vm_api = sub {
my $conf = PVE::QemuConfig->load_config($vmid);
- die "checksum missmatch (file change by other user?)\n"
+ die "checksum mismatch (file change by other user?)\n"
if $digest && $digest ne $conf->{digest};
&$check_cpu_model_access($rpcenv, $authuser, $param, $conf);
@@ -2133,7 +2133,7 @@ __PACKAGE__->register_method({
method => 'POST',
protected => 1,
proxyto => 'node',
- description => "Set virtual machine options (asynchrounous API).",
+ description => "Set virtual machine options (asynchronous API).",
permissions => {
check => ['perm', '/vms/{vmid}', $vm_config_perm_list, any => 1],
},
@@ -2190,7 +2190,7 @@ __PACKAGE__->register_method({
method => 'PUT',
protected => 1,
proxyto => 'node',
- description => "Set virtual machine options (synchrounous API) - You should consider using the POST method instead for any actions involving hotplug or storage allocation.",
+ description => "Set virtual machine options (synchronous API) - You should consider using the POST method instead for any actions involving hotplug or storage allocation.",
permissions => {
check => ['perm', '/vms/{vmid}', $vm_config_perm_list, any => 1],
},
@@ -4488,11 +4488,11 @@ __PACKAGE__->register_method({
not_allowed_nodes => {
type => 'object',
optional => 1,
- description => "List not allowed nodes with additional informations, only passed if VM is offline"
+ description => "List not allowed nodes with additional information, only passed if VM is offline"
},
local_disks => {
type => 'array',
- description => "List local disks including CD-Rom, unsused and not referenced disks"
+ description => "List local disks including CD-Rom, unused and not referenced disks"
},
local_resources => {
type => 'array',
@@ -5018,7 +5018,7 @@ __PACKAGE__->register_method({
my $conf = PVE::QemuConfig->load_config($vmid);
- die "checksum missmatch (file change by other user?)\n"
+ die "checksum mismatch (file change by other user?)\n"
if $digest && $digest ne $conf->{digest};
PVE::QemuConfig->check_lock($conf) if !$skiplock;
diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index d3dbf7b4..8d8ce10a 100755
--- a/PVE/CLI/qm.pm
+++ b/PVE/CLI/qm.pm
@@ -471,7 +471,7 @@ __PACKAGE__->register_method ({
my $pid = PVE::QemuServer::check_running ($vmid);
return if !$pid;
- print "waiting until VM $vmid stopps (PID $pid)\n";
+ print "waiting until VM $vmid stops (PID $pid)\n";
my $count = 0;
while ((!$timeout || ($count < $timeout)) && PVE::QemuServer::check_running ($vmid)) {
@@ -807,7 +807,7 @@ __PACKAGE__->register_method({
type => 'boolean',
optional => 1,
default => 1,
- description => "If set to off, returns the pid immediately instead of waiting for the commmand to finish or the timeout.",
+ description => "If set to off, returns the pid immediately instead of waiting for the command to finish or the timeout.",
},
'timeout' => {
type => 'integer',
diff --git a/PVE/QMPClient.pm b/PVE/QMPClient.pm
index a785d9a1..cf752e28 100644
--- a/PVE/QMPClient.pm
+++ b/PVE/QMPClient.pm
@@ -401,7 +401,7 @@ sub mux_input {
my $obj = from_json($jsons[0]);
my $cmdid = $obj->{'return'};
- die "received responsed without command id\n" if !$cmdid;
+ die "received response without command id\n" if !$cmdid;
# skip results fro previous commands
return if $cmdid < $curcmd->{id};
@@ -440,7 +440,7 @@ sub mux_input {
}
my $cmdid = $obj->{id};
- die "received responsed without command id\n" if !$cmdid;
+ die "received response without command id\n" if !$cmdid;
if ($curcmd->{id} ne $cmdid) {
die "got wrong command id '$cmdid' (expected $curcmd->{id})\n";
@@ -495,7 +495,7 @@ sub mux_eof {
my $obj = from_json($raw);
my $cmdid = $obj->{'return'};
- die "received responsed without command id\n" if !$cmdid;
+ die "received response without command id\n" if !$cmdid;
delete $queue_info->{current};
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index b26da505..2939605f 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -889,7 +889,7 @@ __EOD__
my $net_fmt = {
macaddr => get_standard_option('mac-addr', {
- description => "MAC address. That address must be unique withing your network. This is"
+ description => "MAC address. That address must be unique within your network. This is"
." automatically generated if not specified.",
}),
model => {
@@ -3100,7 +3100,7 @@ sub audio_devs {
push @$devs, '-device', "hda-micro,id=${id}-codec0,bus=${id}.0,cad=0$audiodev";
push @$devs, '-device', "hda-duplex,id=${id}-codec1,bus=${id}.0,cad=1$audiodev";
} else {
- die "unkown audio device '$audio->{dev}', implement me!";
+ die "unknown audio device '$audio->{dev}', implement me!";
}
push @$devs, '-audiodev', "$audio->{backend},id=$audio->{backend_id}";
@@ -6600,7 +6600,7 @@ sub tar_restore_cleanup {
} else {
PVE::Storage::vdisk_free($storecfg, $volid);
}
- print STDERR "temporary volume '$volid' sucessfuly removed\n";
+ print STDERR "temporary volume '$volid' successfully removed\n";
};
print STDERR "unable to cleanup '$volid' - $@" if $@;
} else {
@@ -6875,7 +6875,7 @@ my $restore_destroy_volumes = sub {
my $volid = $dev->{volid} or next;
eval {
PVE::Storage::vdisk_free($storecfg, $volid);
- print STDERR "temporary volume '$volid' sucessfuly removed\n";
+ print STDERR "temporary volume '$volid' successfully removed\n";
};
print STDERR "unable to cleanup '$volid' - $@" if $@;
}
@@ -7829,7 +7829,7 @@ sub convert_iscsi_path {
"file.portal=$portal,file.target=$target,file.lun=$lun,driver=raw";
}
- die "cannot convert iscsi path '$path', unkown format\n";
+ die "cannot convert iscsi path '$path', unknown format\n";
}
sub qemu_img_convert {
diff --git a/PVE/QemuServer/OVF.pm b/PVE/QemuServer/OVF.pm
index b97b0520..eb9cf8e8 100644
--- a/PVE/QemuServer/OVF.pm
+++ b/PVE/QemuServer/OVF.pm
@@ -167,7 +167,7 @@ sub parse_ovf {
$disk_section_path = $1;
$disk_id = $2;
} else {
- warn "invalid host ressource $host_resource, skipping\n";
+ warn "invalid host resource $host_resource, skipping\n";
next;
}
printf "disk section path: $disk_section_path and disk id: $disk_id\n" if $debug;
@@ -181,7 +181,7 @@ ovf:Disk[\@ovf:diskId='%s']/\@ovf:fileRef", $disk_id);
my $valid_url_chars = qr@${valid_uripath_chars}|/@;
if (!$fileref || $fileref !~ m/^${valid_url_chars}+$/) {
- warn "invalid host ressource $host_resource, skipping\n";
+ warn "invalid host resource $host_resource, skipping\n";
next;
}
diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer/PCI.pm
index 1673041b..3b0da39d 100644
--- a/PVE/QemuServer/PCI.pm
+++ b/PVE/QemuServer/PCI.pm
@@ -33,7 +33,7 @@ of PCI virtual functions of the host. HOSTPCIID syntax is:
'bus:dev.func' (hexadecimal numbers)
-You can us the 'lspci' command to list existing PCI devices.
+You can use the 'lspci' command to list existing PCI devices.
Either this or the 'mapping' key must be set.
EODESCR
diff --git a/PVE/QemuServer/USB.pm b/PVE/QemuServer/USB.pm
index 49957444..017ef9c0 100644
--- a/PVE/QemuServer/USB.pm
+++ b/PVE/QemuServer/USB.pm
@@ -33,7 +33,7 @@ my $usb_fmt = {
The Host USB device or port or the value 'spice'. HOSTUSBDEVICE syntax is:
'bus-port(.port)*' (decimal numbers) or
- 'vendor_id:product_id' (hexadeciaml numbers) or
+ 'vendor_id:product_id' (hexadecimal numbers) or
'spice'
You can use the 'lsusb -t' command to list existing usb devices.
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH qemu] fix typos in user-visible strings
2024-10-08 15:14 [pve-devel] [PATCH qemu] fix typos in user-visible strings Maximiliano Sandoval
@ 2024-10-24 11:21 ` Fiona Ebner
0 siblings, 0 replies; 2+ messages in thread
From: Fiona Ebner @ 2024-10-24 11:21 UTC (permalink / raw)
To: Proxmox VE development discussion, Maximiliano Sandoval
Am 08.10.24 um 17:14 schrieb Maximiliano Sandoval:
> This includes docs, and strings printed to stderr or stdout.
>
> These were caught with:
>
> typos --exclude test --exclude changelog
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
applied, thanks!
But please note that it's the "qemu-server" repository, not "qemu" ;)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-24 11:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-08 15:14 [pve-devel] [PATCH qemu] fix typos in user-visible strings Maximiliano Sandoval
2024-10-24 11:21 ` [pve-devel] applied: " Fiona Ebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal