* [pve-devel] [PATCH installer] auto: tests: fix up lvm swapsize test after heuristic change
@ 2025-07-15 13:43 Christoph Heiss
2025-07-15 13:55 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Heiss @ 2025-07-15 13:43 UTC (permalink / raw)
To: pve-devel
The heuristic was changed in the commit mentioned below, the respective
test needs adjustment too.
Fixes: 08136f8 ("avoid artificial limit and allow using up to half of hdsize as swap")
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
.../parse_answer_fail/lvm_swapsize_greater_than_hdsize.json | 2 +-
.../parse_answer_fail/lvm_swapsize_greater_than_hdsize.toml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.json b/proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.json
index aa4f7fe..e0e59c5 100644
--- a/proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.json
+++ b/proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.json
@@ -1,3 +1,3 @@
{
- "error": "Swap size 4.01 GiB cannot be greater than 4 GiB (hard disk size / 8)"
+ "error": "Swap size 16.01 GiB cannot be greater than 16 GiB (hard disk size / 2)"
}
diff --git a/proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.toml b/proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.toml
index ffe16dc..22a7f6b 100644
--- a/proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.toml
+++ b/proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.toml
@@ -11,6 +11,6 @@ source = "from-dhcp"
[disk-setup]
filesystem = "ext4"
-lvm.swapsize = 4.01
+lvm.swapsize = 16.01
lvm.hdsize = 32
disk-list = ["sda"]
--
2.49.0
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH installer] auto: tests: fix up lvm swapsize test after heuristic change
2025-07-15 13:43 [pve-devel] [PATCH installer] auto: tests: fix up lvm swapsize test after heuristic change Christoph Heiss
@ 2025-07-15 13:55 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2025-07-15 13:55 UTC (permalink / raw)
To: Proxmox VE development discussion, Christoph Heiss
Am 15.07.25 um 15:43 schrieb Christoph Heiss:
> The heuristic was changed in the commit mentioned below, the respective
> test needs adjustment too.
>
> Fixes: 08136f8 ("avoid artificial limit and allow using up to half of hdsize as swap")
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> .../parse_answer_fail/lvm_swapsize_greater_than_hdsize.json | 2 +-
> .../parse_answer_fail/lvm_swapsize_greater_than_hdsize.toml | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-15 13:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-15 13:43 [pve-devel] [PATCH installer] auto: tests: fix up lvm swapsize test after heuristic change Christoph Heiss
2025-07-15 13:55 ` [pve-devel] applied: " Thomas Lamprecht
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.