From: Lukas Wagner <l.wagner@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup 2/3] node: status: added bootmode
Date: Mon, 27 Nov 2023 09:32:15 +0100 [thread overview]
Message-ID: <5d7a6058-9937-4945-94e5-0136a397c402@proxmox.com> (raw)
In-Reply-To: <7173334e-f855-40c1-ab9f-a9b3c5fecc57@proxmox.com>
On 11/27/23 09:26, Gabriel Goller wrote:
> On 11/24/23 15:20, Lukas Wagner wrote:
>
>>
>>
>> On 11/24/23 13:02, Gabriel Goller wrote:
>>> +fn boot_mode_to_info(bm: boot_mode::BootModeInformation) ->
>>> BootModeInformation {
>>> + match bm {
>>> + boot_mode::BootModeInformation::Efi =>
>>> BootModeInformation::Efi,
>>> + boot_mode::BootModeInformation::EfiSecureBoot =>
>>> BootModeInformation::EfiSecureBoot,
>>> + boot_mode::BootModeInformation::Bios =>
>>> BootModeInformation::Bios,
>>> + }
>>> +}
>>
>> Mini nit: Maybe a From<boot_mode::BootModeInformation> impl would be a
>> bit more idiomatic?
> Thought about this as well, but sadly the orphan rule ruins the day :(
> I also don't want to import `proxmox_sys` in `pbs-api-types` or viceversa.
>>
Ah yes, orphan rules... of course, didn't think about them during the
review :D
--
- Lukas
next prev parent reply other threads:[~2023-11-27 8:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 12:02 [pbs-devel] [PATCH v2 proxmox{-backup, } 0/3] Add boot_mode, improve kernel version Gabriel Goller
2023-11-24 12:02 ` [pbs-devel] [PATCH v2 proxmox 1/3] sys: add function to get boot_mode Gabriel Goller
2023-11-24 14:19 ` Lukas Wagner
2023-11-24 12:02 ` [pbs-devel] [PATCH v2 proxmox-backup 2/3] node: status: added bootmode Gabriel Goller
2023-11-24 14:20 ` Lukas Wagner
2023-11-27 8:26 ` Gabriel Goller
2023-11-27 8:32 ` Lukas Wagner [this message]
2023-11-24 12:02 ` [pbs-devel] [PATCH v2 proxmox-backup 3/3] node: status: declutter kernel-version Gabriel Goller
2023-11-24 14:19 ` Lukas Wagner
2023-11-27 8:35 ` Gabriel Goller
2023-11-24 14:18 ` [pbs-devel] [PATCH v2 proxmox{-backup, } 0/3] Add boot_mode, improve kernel version Lukas Wagner
2023-11-24 14:45 ` Thomas Lamprecht
2023-11-27 8:41 ` Gabriel Goller
2023-11-27 8:56 ` Gabriel Goller
2023-11-27 9:13 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d7a6058-9937-4945-94e5-0136a397c402@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.