all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Oguz Bektas <o.bektas@proxmox.com>
Subject: Re: [pve-devel] [PATCH v4 container 0/2] post_clone hook for containers
Date: Wed, 16 Jun 2021 15:48:42 +0200	[thread overview]
Message-ID: <5d74bd92-63b0-5525-a7e1-7a561e92d54d@proxmox.com> (raw)
In-Reply-To: <20210616132422.1768676-1-o.bektas@proxmox.com>

On 16.06.21 15:24, Oguz Bektas wrote:
> fixes #3443 by implementing post_clone_hook for containers (which at the
> moment only generates a unique /etc/machine-id for the cloned
> container). this can be reused later for other things we want to do post
> clone.
> 

what are the changes since v3? I did not found any note here nor in the actual
patches.

> 
> 
> Oguz Bektas (2):
>   setup: add post_clone_hook for containers
>   run post_clone_hook in clone_vm
> 
>  src/PVE/API2/LXC.pm       | 37 ++++++++++++++++++++++++++++++-------
>  src/PVE/LXC/Setup.pm      | 12 ++++++++++++
>  src/PVE/LXC/Setup/Base.pm | 31 +++++++++++++++++++++++++++++++
>  3 files changed, 73 insertions(+), 7 deletions(-)
> 





  parent reply	other threads:[~2021-06-16 13:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16 13:24 Oguz Bektas
2021-06-16 13:24 ` [pve-devel] [PATCH v4 container 1/2] setup: add post_clone_hook " Oguz Bektas
2021-06-16 13:24 ` [pve-devel] [PATCH v4 container 2/2] run post_clone_hook in clone_vm Oguz Bektas
2021-06-16 13:48 ` Thomas Lamprecht [this message]
2021-06-16 14:04   ` [pve-devel] [PATCH v4 container 0/2] post_clone hook for containers Oguz Bektas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d74bd92-63b0-5525-a7e1-7a561e92d54d@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=o.bektas@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal