From: Stefan Reiter <s.reiter@proxmox.com>
To: Fabian Ebner <f.ebner@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH qemu-server] tests: mock storage locking for migration tests
Date: Mon, 11 Jan 2021 14:08:35 +0100 [thread overview]
Message-ID: <5d4b5ce4-2ebe-32e8-e236-622acc800c46@proxmox.com> (raw)
In-Reply-To: <20210111123409.24995-1-f.ebner@proxmox.com>
On 1/11/21 1:34 PM, Fabian Ebner wrote:
> by doing it in a local directory instead of /var/lock/pve-manager, which is
> used by the installed/non-test PVE code. This also covers the shared case,
> which will become relevant after fixing #3229 (currently migration doesn't
> touch disks on shared storages).
>
> Reported-by: Stefan Reiter <s.reiter@proxmox.com>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Fixes the issue, though it still fails if you have previously made a
build as root, since 'MigrationTest/run' will have the wrong
permissions. Maybe include that dir in 'make clean'?
next prev parent reply other threads:[~2021-01-11 13:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 12:34 Fabian Ebner
2021-01-11 13:08 ` Stefan Reiter [this message]
2021-01-12 11:02 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d4b5ce4-2ebe-32e8-e236-622acc800c46@proxmox.com \
--to=s.reiter@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal