all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Max Carrara <m.carrara@proxmox.com>
Subject: Re: [pve-devel] [RFC v1 pve-storage 1/2] (rfc) example: sshfs plugin: add custom storage plugin for sshfs
Date: Mon, 31 Mar 2025 10:06:08 +0200	[thread overview]
Message-ID: <5d2f7aa2-22c7-4d61-bda9-2256e82c275a@proxmox.com> (raw)
In-Reply-To: <20250328171209.503132-1-m.carrara@proxmox.com>

Am 28.03.25 um 18:12 schrieb Max Carrara:
> - What would be the preferred way to allow specifying whether a
>   (custom) plugin is shared or not via our API?
> 
>   E.g. some external plugins do the following, which (I suppose)
>   wasn't originally part of the API, but is now, due it being used in
>   the wild:
> 
>     push @PVE::Storage::Plugin::SHARED_STORAGE, 'some-custom-plugin';
> 
>   Would be open for any suggestions on how to support this properly!
>   Perhaps as a flag in `plugindata()`?

Yes, could be done as a storage feature [0].

> - Should we allow custom plugins to define sensitive properties for
>   their own purposes? If so, how?
> 
>   Currently, sensitive props are hardcoded [2] which is sub-optimal,
>   but gets the job done. However, should third-party plugin authors
>   need additional / different properties, there's currently no way to
>   support this. This would perhaps also be useful for this plugin
>   here, as one could e.g. provide a path to a password file to use for
>   something like sshpass [3] or similar, but I'm not really sure about
>   this yet.
> 
> The reason why I'm bringing this up is because the upcoming guide in
> the wiki could benefit from a demonstration on how to implement /
> handle both cases. Network storages are quite common, can be shared
> among nodes in most cases, and may also require one to handle
> authentication.

See here [0][1] ;)

[0]:
https://lore.proxmox.com/pve-devel/20250321134852.103871-8-f.ebner@proxmox.com/
[1]:
https://lore.proxmox.com/pve-devel/20250321134852.103871-11-f.ebner@proxmox.com/


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-03-31  8:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-28 17:12 Max Carrara
2025-03-28 17:12 ` [pve-devel] [RFC v1 pve-storage 2/2] (rfc) example: sshfs plugin: package SSHFSPlugin.pm Max Carrara
2025-03-31  8:06 ` Fiona Ebner [this message]
2025-04-02  8:45   ` [pve-devel] [RFC v1 pve-storage 1/2] (rfc) example: sshfs plugin: add custom storage plugin for sshfs Max Carrara
2025-04-16 12:55 ` [pve-devel] superseded: " Max Carrara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d2f7aa2-22c7-4d61-bda9-2256e82c275a@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=m.carrara@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal