Re: [pve-devel] [PATCH pve_manager 1/1] Translate units

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

The subject is very lacking, if I'd stuble over this when skimming through a
git log --oneline or the like, which I find myself doing very often in repos,
I'd have no idea what this is about – translation is used for a myriad of things
in IT and units too; also no subsystem tag - so no idea if this is API, UI, or
something else. Also no reference to the enhancement request this addresses.

I'd prefer something like:

fix #4551: ui: use gettext for byte units

or

fix #4551: ui: make byte units translatable

Am 04/04/2023 um 12:14 schrieb Noel Ullreich:
> added `gettext` to units that were "hardcoded"

this doesn't adds that much information, as I can gather the "what?" from checking
the change itself, at least here as it's relatively trivial.

So rather add some reasoning, i.e., "why?"; something like that byte isn't actually
an SI-Unit and is not commonly used in some languages, like e.g., French, and that
some languages are even translating SI-Prefixes into their script.

> 
> Signed-off-by: Noel Ullreich <n.ullreich@proxmox.com>
> ---
>  www/manager6/ceph/OSD.js                 | 4 ++--
>  www/manager6/form/DiskStorageSelector.js | 2 +-
>  www/manager6/lxc/MPResize.js             | 2 +-
>  www/manager6/qemu/HDResize.js            | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/www/manager6/ceph/OSD.js b/www/manager6/ceph/OSD.js
> index 2f12f94d..40226f7a 100644
> --- a/www/manager6/ceph/OSD.js
> +++ b/www/manager6/ceph/OSD.js
> @@ -83,7 +83,7 @@ Ext.define('PVE.CephCreateOsd', {
>  			{
>  			    xtype: 'numberfield',
>  			    name: 'db_dev_size',
> -			    fieldLabel: gettext('DB size') + ' (GiB)',
> +			    fieldLabel: gettext('DB size') + ' ' + gettext('GiB'),

1. you dropped the parenthesis
2. can we please switch to template strings when touching such lines

fieldLabel: `${gettext('DB size')} (${gettext('GiB')})`,

>  			    minValue: 1,
>  			    maxValue: 128*1024,
>  			    decimalPrecision: 2,
> @@ -137,7 +137,7 @@ Ext.define('PVE.CephCreateOsd', {
>  			{
>  			    xtype: 'numberfield',
>  			    name: 'wal_dev_size',
> -			    fieldLabel: gettext('WAL size') + ' (GiB)',
> +			    fieldLabel: gettext('WAL size') + ' ' + gettext('GiB'),

same as above on both points

>  			    minValue: 0.5,
>  			    maxValue: 128*1024,
>  			    decimalPrecision: 2,
> diff --git a/www/manager6/form/DiskStorageSelector.js b/www/manager6/form/DiskStorageSelector.js
> index abd46deb..0e6dee40 100644
> --- a/www/manager6/form/DiskStorageSelector.js
> +++ b/www/manager6/form/DiskStorageSelector.js
> @@ -148,7 +148,7 @@ Ext.define('PVE.form.DiskStorageSelector', {
>  		itemId: 'disksize',
>  		reference: 'disksize',
>  		name: 'disksize',
> -		fieldLabel: gettext('Disk size') + ' (GiB)',
> +		fieldLabel: gettext('Disk size') + ' ' + gettext('GiB'),

same as above on both pointss



>  		hidden: me.hideSize,
>  		disabled: me.hideSize,
>  		minValue: 0.001,
> diff --git a/www/manager6/lxc/MPResize.js b/www/manager6/lxc/MPResize.js
> index 881c037b..292979b6 100644
> --- a/www/manager6/lxc/MPResize.js
> +++ b/www/manager6/lxc/MPResize.js
> @@ -52,7 +52,7 @@ Ext.define('PVE.window.MPResize', {
>  	    maxValue: 128*1024,
>  	    decimalPrecision: 3,
>  	    value: '0',
> -	    fieldLabel: gettext('Size Increment') + ' (GiB)',
> +	    fieldLabel: gettext('Size Increment') + ' ' + gettext('GiB'),

same as above on both points

>  	    allowBlank: false,
>  	});
>  
> diff --git a/www/manager6/qemu/HDResize.js b/www/manager6/qemu/HDResize.js
> index f9c7290d..d8131663 100644
> --- a/www/manager6/qemu/HDResize.js
> +++ b/www/manager6/qemu/HDResize.js
> @@ -49,7 +49,7 @@ Ext.define('PVE.window.HDResize', {
>  	    maxValue: 128*1024,
>  	    decimalPrecision: 3,
>  	    value: '0',
> -	    fieldLabel: gettext('Size Increment') + ' (GiB)',
> +	    fieldLabel: gettext('Size Increment') + ' ' + gettext('GiB'),

same as above on both points

>  	    allowBlank: false,
>  	});
>