[pve-devel] [RFC qemu] block/gluster: do not warn about deprecation

[pve-devel] [RFC qemu] block/gluster: do not warn about deprecation

[Fiona Ebner]

Proxmox VE will not drop the GlusterFS plugin during the PVE 8.x
support lifecycle. Avoid scaring users early.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---

The plan is to warn users with pve8to9, but sent as RFC, because
keeping this early heads-up is not too bad either.

 block/gluster.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/block/gluster.c b/block/gluster.c
index c3a9555591..af608731ec 100644
--- a/block/gluster.c
+++ b/block/gluster.c
@@ -816,8 +816,6 @@ static int qemu_gluster_open(BlockDriverState *bs,  QDict *options,
         goto out;
     }
 
-    warn_report_once("'gluster' is deprecated");
-
     filename = qemu_opt_get(opts, GLUSTER_OPT_FILENAME);
 
     s->debug = qemu_opt_get_number(opts, GLUSTER_OPT_DEBUG,
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [RFC qemu] block/gluster: do not warn about deprecation

[Thomas Lamprecht]

Am 11.04.25 um 11:37 schrieb Fiona Ebner:
> Proxmox VE will not drop the GlusterFS plugin during the PVE 8.x
> support lifecycle. Avoid scaring users early.

Those warnings from QEMU come up as standard info in the task log IIRC?
I.e., not as task warning on our side. In that case, it might be nicer
to just add a bit context, something like:

----8<----
Native 'gluster' support will be deprecated and removed in Proxmox VE 9.
Before upgrading to the next major version, you will need to switch to accessing your Gluster storage as directory storage or migrate to another storage type.
---->8----

Or a shorter variant:

----8<----
Native Gluster support will be removed in Proxmox VE 9.
Before upgrading, switch to accessing Gluster as directory storage or migrate to a different storage type.
---->8----

That might be less scaring while still conveying info to users that sooner
or later need to do something about this–well, besides choosing to not upgrade
ever. What do you think?


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [RFC qemu] block/gluster: do not warn about deprecation

[Fiona Ebner]

Am 02.06.25 um 08:33 schrieb Thomas Lamprecht:
> Am 11.04.25 um 11:37 schrieb Fiona Ebner:
>> Proxmox VE will not drop the GlusterFS plugin during the PVE 8.x
>> support lifecycle. Avoid scaring users early.
> 
> Those warnings from QEMU come up as standard info in the task log IIRC?

Yes, exactly.

> I.e., not as task warning on our side. In that case, it might be nicer
> to just add a bit context, something like:
> 
> ----8<----
> Native 'gluster' support will be deprecated and removed in Proxmox VE 9.
> Before upgrading to the next major version, you will need to switch to accessing your Gluster storage as directory storage or migrate to another storage type.
> ---->8----
> 
> Or a shorter variant:
> 
> ----8<----
> Native Gluster support will be removed in Proxmox VE 9.
> Before upgrading, switch to accessing Gluster as directory storage or migrate to a different storage type.
> ---->8----
> 
> That might be less scaring while still conveying info to users that sooner
> or later need to do something about this–well, besides choosing to not upgrade
> ever. What do you think?

Ack, will send a v2!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel