From: Filip Schauer <f.schauer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH v2 storage] fix #5191: api, cli: implement moving a volume between storages
Date: Wed, 3 Jul 2024 15:01:09 +0200 [thread overview]
Message-ID: <5ccdf9d0-f1df-4d8d-be2f-d3fc760dabd8@proxmox.com> (raw)
In-Reply-To: <1719392256.qae9r5a2eh.astroid@yuna.none>
On 26/06/2024 11:58, Fabian Grünbichler wrote:
>> @@ -1613,6 +1615,15 @@ sub volume_export {
>> run_command(['tar', @COMMON_TAR_FLAGS, '-cf', '-', '-C', $file, '.'],
>> output => '>&'.fileno($fh));
>> return;
>> + } elsif ($format eq 'backup+size') {
> nit: vma+size would be more in line with our current naming scheme
> here.. even if it contains the extra attributes, 'backup' is quite
> generic..
It is generic because it is not limited to VMA backups. This covers any
kind of backup.
Superseded by:
https://lists.proxmox.com/pipermail/pve-devel/2024-July/064406.html
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-07-03 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-25 14:53 Filip Schauer
2024-06-26 9:58 ` Fabian Grünbichler
2024-07-03 13:01 ` Filip Schauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ccdf9d0-f1df-4d8d-be2f-d3fc760dabd8@proxmox.com \
--to=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal