all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stefan Hanreich <s.hanreich@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server v3] rollback: Only create start task with --start if VM is not running
Date: Fri, 30 Dec 2022 15:56:32 +0100	[thread overview]
Message-ID: <5cbd0ad2-f9fb-c9c9-f381-2f21e98f6442@proxmox.com> (raw)
In-Reply-To: <20221221165110.303770-1-s.hanreich@proxmox.com>

Am 21/12/2022 um 17:51 schrieb Stefan Hanreich:
> When rolling back to the snapshot of a VM that includes RAM, the VM
> gets started by the rollback task anyway, so no additional start task
> is needed. Previously, when rolling back with the start parameter and
> the VM snapshot included RAM, a start task was created. That task
> failed because the VM had already been started by the rollback task.
> 
> Additionally documented this behaviour in the description of the start
> parameter
> 
> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
> ---
> Changes v2 -> v3:
> Use vm_running_locally() instead of check_running()
> Improved description
> 
> Changes v1 -> v2:
> Do not parse config for checking type of snapshot but rather directly check
> whether VM is running or not via check_running()
> 
>  PVE/API2/Qemu.pm | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
>

applied, thanks!




      reply	other threads:[~2022-12-30 14:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-21 16:51 [pve-devel] " Stefan Hanreich
2022-12-30 14:56 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5cbd0ad2-f9fb-c9c9-f381-2f21e98f6442@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.hanreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal