From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Erik Fastermann <e.fastermann@proxmox.com>, pdm-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox-datacenter-manager v2] fix #7187: report: add ethtool output for physical interfaces
Date: Fri, 15 May 2026 09:58:54 +0200 [thread overview]
Message-ID: <5c60b579-6d0e-4621-8053-a105f5244fd9@proxmox.com> (raw)
In-Reply-To: <20260513085115.2695-1-e.fastermann@proxmox.com>
On 13/05/2026 10:49, Erik Fastermann wrote:
> Adding ethtool output to the report provides visibility into actual and
> supported NIC link speeds, making it much easier to diagnose network
> performance issues, negotiation failures, and configuration mismatches.
> It also reduces support back-and-forth.
>
> The implementation mirrors the change in proxmox-backup, as the report
> functionality in pdm is adapted from there.
>
> Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
> ---
>
> NOTE: A similar patch was applied to all products:
s/applied to/submitted for/ as the former suggested it's already in the main
git repository.
> pmg, pve, pbs, pdm.
>
> changes since v1:
> * add a more detailed commit message explaining the rational
missed the v2, but my review for the v1 still applies:
https://lore.proxmox.com/all/9a7d3a53-9b05-4ddb-94af-662ff2ffff1b@proxmox.com/
prev parent reply other threads:[~2026-05-15 7:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 8:51 [PATCH proxmox-datacenter-manager v2] fix #7187: report: add ethtool output for physical interfaces Erik Fastermann
2026-05-15 7:58 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c60b579-6d0e-4621-8053-a105f5244fd9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=e.fastermann@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.