From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id EDB101FF14C for ; Fri, 15 May 2026 09:59:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E36C1F1F5; Fri, 15 May 2026 09:59:29 +0200 (CEST) Message-ID: <5c60b579-6d0e-4621-8053-a105f5244fd9@proxmox.com> Date: Fri, 15 May 2026 09:58:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH proxmox-datacenter-manager v2] fix #7187: report: add ethtool output for physical interfaces To: Erik Fastermann , pdm-devel@lists.proxmox.com References: <20260513085115.2695-1-e.fastermann@proxmox.com> Content-Language: en-US, de-DE From: Thomas Lamprecht In-Reply-To: <20260513085115.2695-1-e.fastermann@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778831929128 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: VYW6YJTNZFC2P2MVSO2NCST6CRRAE2QM X-Message-ID-Hash: VYW6YJTNZFC2P2MVSO2NCST6CRRAE2QM X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Datacenter Manager development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 13/05/2026 10:49, Erik Fastermann wrote: > Adding ethtool output to the report provides visibility into actual and > supported NIC link speeds, making it much easier to diagnose network > performance issues, negotiation failures, and configuration mismatches. > It also reduces support back-and-forth. > > The implementation mirrors the change in proxmox-backup, as the report > functionality in pdm is adapted from there. > > Signed-off-by: Erik Fastermann > --- > > NOTE: A similar patch was applied to all products: s/applied to/submitted for/ as the former suggested it's already in the main git repository. > pmg, pve, pbs, pdm. > > changes since v1: > * add a more detailed commit message explaining the rational missed the v2, but my review for the v1 still applies: https://lore.proxmox.com/all/9a7d3a53-9b05-4ddb-94af-662ff2ffff1b@proxmox.com/