From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 qemu] block/gluster: provider more context for deprecation warning
Date: Wed, 25 Jun 2025 19:18:36 +0200 [thread overview]
Message-ID: <5c0de667-97fa-4c50-b41d-83b05b8e7777@proxmox.com> (raw)
In-Reply-To: <20250602110730.156144-1-f.ebner@proxmox.com>
Am 02.06.25 um 13:07 schrieb Fiona Ebner:
> Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> Changes in v2:
> * Instead of removing the warning, provide more context.
>
> block/gluster.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/block/gluster.c b/block/gluster.c
> index c3a9555591..71c4a60b02 100644
> --- a/block/gluster.c
> +++ b/block/gluster.c
> @@ -816,7 +816,11 @@ static int qemu_gluster_open(BlockDriverState *bs, QDict *options,
> goto out;
> }
>
> - warn_report_once("'gluster' is deprecated");
> + warn_report_once("Native 'gluster' support will be deprecated and removed"
> + " in Proxmox VE 9.");
> + warn_report_once("Before upgrading, switch to accessing your Gluster"
> + " storage as a directory storage or migrate to another"
> + " storage type.");
>
> filename = qemu_opt_get(opts, GLUSTER_OPT_FILENAME);
>
Acked-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
can you please apply this on the stable-bookworm and upload
a new version so that we can get this warning out over the
next few weeks? Maybe there are some stable fixes that make
a bump more worthwhile, but no hard feelings there.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-06-25 17:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-02 11:07 Fiona Ebner
2025-06-25 17:18 ` Thomas Lamprecht [this message]
2025-07-02 12:36 ` [pve-devel] applied: " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c0de667-97fa-4c50-b41d-83b05b8e7777@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.