all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [RFC PATCH manager] ui: render 'protected' column as icon and enable sorting
Date: Tue, 16 Nov 2021 14:11:22 +0100	[thread overview]
Message-ID: <5bfbffc1-0774-db3d-8e0d-d4f3f7411bae@proxmox.com> (raw)
In-Reply-To: <20211116112036.3423536-1-d.csapak@proxmox.com>

On 16.11.21 12:20, Dominik Csapak wrote:
> instead of 'Yes' and 'No', render the same icon as in pbs for protected
> backups, and leave the column empty otherwise
> 
> this makes the difference much more visible and is more consistent with
> how we present that flag in pbs
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> i initially wanted to add it to the text, but that seemed a bit weird.
> i'd let people convince me though, if there is a strong argument..
> 

crowding the interface has some real cost, especially for new users, while
iconfying everything is surely also not ideal for UX I think it's OK here.

>  www/manager6/grid/BackupView.js     | 3 ++-
>  www/manager6/storage/ContentView.js | 3 ++-
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
>

applied, thanks!




      reply	other threads:[~2021-11-16 13:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 11:20 [pve-devel] " Dominik Csapak
2021-11-16 13:11 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5bfbffc1-0774-db3d-8e0d-d4f3f7411bae@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal